Add checkbox for reporting invalid TLS/SSL cert chains

chrome/browser/net/certificate_error_reporter.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
 #define CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
 
 #include <set>
 #include <string>
 
 #include "base/macros.h"
+#include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "net/url_request/url_request.h"
 #include "url/gurl.h"
 
 namespace net {
 class URLRequestContext;
 class SSLInfo;
 }
 
 namespace chrome_browser_net {
 
 class CertLoggerRequest;
 
+extern const char kExtendedReportingUploadUrl[];
+
 // Provides functionality for sending reports about invalid SSL
 // certificate chains to a report collection server.
-class CertificateErrorReporter : public net::URLRequest::Delegate {
+class CertificateErrorReporter
+    : public net::URLRequest::Delegate,
+      public base::RefCountedThreadSafe<CertificateErrorReporter> {

[Ryan Sleevi, 2015/03/14 03:09:42]

Definitely don't want to do this

[estark, 2015/03/16 23:40:52]

Done.

  public:
   // These represent the types of reports that can be sent.
   enum ReportType {
     // A report of a certificate chain that failed a certificate pinning
     // check.
     REPORT_TYPE_PINNING_VIOLATION,
     // A report for an invalid certificate chain that is being sent for
     // a user who has opted-in to the extended reporting program.
     REPORT_TYPE_EXTENDED_REPORTING
   };
 
   // Create a certificate error reporter that will send certificate
   // error reports to |upload_url|, using |request_context| as the
   // context for the reports.
   CertificateErrorReporter(net::URLRequestContext* request_context,
                            const GURL& upload_url);
 
-  ~CertificateErrorReporter() override;
+  // Create a certificate error reporter that will send certificate
+  // error reports to |upload_url|. A request context will have to be
+  // specified when calling |SendReport|. Useful for constructing
+  // reporters when not on the IO thread.
+  explicit CertificateErrorReporter(const GURL& upload_url);
 
   // Construct, serialize, and send a certificate reporter to the report
   // collection server containing the |ssl_info| associated with a
   // connection to |hostname|.
   virtual void SendReport(ReportType type,
                           const std::string& hostname,
                           const net::SSLInfo& ssl_info);
+  // Construct, serialize, and send a certificate reporter to the report

[felt, 2015/03/13 19:18:11]

Is this sending a cert "report", or a cert "reporter"?

[estark, 2015/03/16 23:40:52]

Done.

+  // collection server containing the |ssl_info| associated with a
+  // connection to |hostname|. Uses |request_context| as the context for
+  // the request sent to the server.
+  virtual void SendReport(ReportType type,
+                          net::URLRequestContext* request_context,
+                          const std::string& hostname,
+                          const net::SSLInfo& ssl_info);
 
   // net::URLRequest::Delegate
   void OnResponseStarted(net::URLRequest* request) override;
   void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
 
+ protected:
+  ~CertificateErrorReporter() override;
+
  private:
+  friend class base::RefCountedThreadSafe<CertificateErrorReporter>;
+
   // Create a URLRequest with which to send a certificate report to the
   // server.
   virtual scoped_ptr<net::URLRequest> CreateURLRequest(
       net::URLRequestContext* context);
 
   // Serialize and send a CertLoggerRequest protobuf to the report
   // collection server.
   void SendCertLoggerRequest(const CertLoggerRequest& request);
 
   // Populate the CertLoggerRequest for a report.
   static void BuildReport(const std::string& hostname,
                           const net::SSLInfo& ssl_info,
                           CertLoggerRequest* out_request);
 
   // Performs post-report cleanup.
   void RequestComplete(net::URLRequest* request);
 
   net::URLRequestContext* const request_context_;
   const GURL upload_url_;
 
   // Owns the contained requests.
   std::set<net::URLRequest*> inflight_requests_;
 
   DISALLOW_COPY_AND_ASSIGN(CertificateErrorReporter);
 };
 
 }  // namespace chrome_browser_net
 
 #endif  // CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_