Add checkbox for reporting invalid TLS/SSL cert chains

chrome/browser/interstitials/security_interstitial_page.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_
 #define CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_
 
 #include "base/strings/string16.h"
 #include "content/public/browser/interstitial_page_delegate.h"
 #include "url/gurl.h"
@@ skipping 45 matching lines @@
   const GURL request_url_;
   // Once shown, |interstitial_page| takes ownership of this
   // SecurityInterstitialPage instance.
   content::InterstitialPage* interstitial_page_;
   // Whether the interstitial should create a view.
   bool create_view_;
 
   DISALLOW_COPY_AND_ASSIGN(SecurityInterstitialPage);
 };
 
+class SecurityInterstitialPageWithExtendedReporting

[felt, 2015/02/19 00:32:32]

I'm debating the pros and cons of having this as a separate subclass vs just
putting these methods directly on the SecurityInterstitialPage, with the captive
portal simply not implementing anything for PopulateExtendedReportingOption. Why
did you choose to do it this way (with a separate subclass)?

[estark, 2015/02/19 02:32:08]

Hmm, TBH the latter option didn't really occur to me. What are the pros and cons
you're thinking of? The main (somewhat superficial) argument I can think of is
that SecurityInterstitialPageWithExtendedReporting is just a really annoyingly
long name.

[felt, 2015/02/20 19:20:34]

Pro - it cleanly separates out the reporting logic

Con - it seems like a possibly unnecessary extra subclass; furthermore there may
be interstitials that don't show the reporting stuff anyway (e.g. enterprise
config) and so it isn't really a clean separateion between pages with and
without extended reporting

[estark, 2015/02/23 20:42:18]

Okay, I find that Con fairly convincing -- done.

+    : public SecurityInterstitialPage {
+ public:
+  SecurityInterstitialPageWithExtendedReporting(
+      content::WebContents* web_contents,
+      const GURL& url);
+
+ protected:
+  // Record the user's preference for reporting information about
+  // malware and SSL errors.
+  void SetReportingPreference(bool report);
+
+  // Fills the passed dictionary with the values to be passed to the template
+  // when creating the HTML.
+  virtual void PopulateExtendedReportingOption(
+      base::DictionaryValue* load_time_data) = 0;
+
+  // Returns the boolean value of the given |pref| from the PrefService of the
+  // Profile associated with |web_contents_|.
+  bool IsPrefEnabled(const char* pref);
+};
+
+namespace interstitials {
+// Constants used to communicate with the JavaScript.
+extern const char kBoxChecked[];
+extern const char kDisplayCheckBox[];
+extern const char kPrivacyLinkHtml[];
+}
+
 #endif  // CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_