Add checkbox for reporting invalid TLS/SSL cert chains

chrome/browser/ssl/ssl_blocking_page.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
 
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/strings/string16.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "base/time/time.h"
 #include "chrome/browser/interstitials/security_interstitial_metrics_helper.h"
 #include "chrome/browser/interstitials/security_interstitial_page.h"
 #include "net/ssl/ssl_info.h"
+#include "net/url_request/url_request_context_getter.h"

[Ryan Sleevi, 2015/02/27 00:46:33]

Forward declare

[estark, 2015/02/27 02:49:37]

Just removed the #include all together because I moved
|FinishCertCollectionInternal| out of the class, but this prompted me to go look
up when to forward declare in the style guide, so hooray I learned something
useful :)

 #include "url/gurl.h"
 
 #if defined(ENABLE_EXTENSIONS)
 namespace extensions {
 class ExperienceSamplingEvent;
 }
 #endif
 
 class SSLErrorClassification;
 
 // This class is responsible for showing/hiding the interstitial page that is
 // shown when a certificate error happens.
 // It deletes itself when the interstitial page is closed.
 class SSLBlockingPage : public SecurityInterstitialPage {
  public:
-  // These represent the commands sent from the interstitial JavaScript. They
-  // are defined in chrome/browser/resources/ssl/ssl_errors_common.js.
-  // DO NOT reorder or change these without also changing the JavaScript!
+  // These represent the commands sent from the interstitial
+  // JavaScript. They are defined in
+  // chrome/browser/resources/security_warnings/ssl_errors_common.js.
+  // DO NOT reorder or change these without also changing the
+  // JavaScript!
   enum SSLBlockingPageCommands {
     CMD_DONT_PROCEED = 0,
     CMD_PROCEED = 1,
     CMD_MORE = 2,
     CMD_RELOAD = 3,
     CMD_HELP = 4,
-    CMD_CLOCK = 5
+    CMD_CLOCK = 5,
+    CMD_DO_REPORT = 6,
+    CMD_DONT_REPORT = 7
   };
 
   enum SSLBlockingPageOptionsMask {
     // Indicates whether or not the user could (assuming perfect knowledge)
     // successfully override the error and still get the security guarantees
     // of TLS.
     OVERRIDABLE = 1 << 0,
     // Indicates whether or not the site the user is trying to connect to has
     // requested strict enforcement of certificate validation (e.g. with HTTP
     // Strict-Transport-Security).
@@ skipping 31 matching lines @@
   void OverrideEntry(content::NavigationEntry* entry) override;
   void OverrideRendererPrefs(content::RendererPreferences* prefs) override;
   void OnProceed() override;
   void OnDontProceed() override;
 
   // SecurityInterstitialPage implementation:
   bool ShouldCreateNewNavigation() const override;
   void PopulateInterstitialStrings(
       base::DictionaryValue* load_time_data) override;
 
+  // SecurityInterstitialPageWithExtendedReporting implementation:
+  void PopulateExtendedReportingOption(
+      base::DictionaryValue* load_time_data) override;
+
  private:
   void NotifyDenyCertificate();
   void NotifyAllowCertificate();
 
   std::string GetUmaHistogramPrefix() const;
   std::string GetSamplingEventName() const;
 
+  // Send a report about an invalid certificate to the server (by
+  // posting a FinishCertCollectionInternal task to the IO thread).
+  void FinishCertCollection();
+
+  // The method that actually sends the cert collection report over the
+  // network. Must be called only on the IO thread.
+  static void FinishCertCollectionInternal(
+      scoped_refptr<net::URLRequestContextGetter> request_context_getter,

[Ryan Sleevi, 2015/02/27 00:46:33]

This should be "const scoped_refptr<net::URLRequestContextGetter>&"

[estark, 2015/02/27 02:49:37]

Done.

+      const std::string& hostname,
+      const net::SSLInfo& ssl_info);
+
   base::Callback<void(bool)> callback_;
 
   const int cert_error_;
   const net::SSLInfo ssl_info_;
   // There are two ways for the user to override an interstitial:
   //
   // overridable_) By clicking on "Advanced" and then "Proceed".
   //   - This corresponds to "the user can override using the UI".
   // danger_overridable_) By typing the word "danger".
   //   - This is an undocumented workaround.
@@ skipping 11 matching lines @@
   // Which type of interstitial this is.
   enum SSLInterstitialReason {
     SSL_REASON_SSL,
     SSL_REASON_BAD_CLOCK
   } interstitial_reason_;
 
   DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage);
 };
 
 #endif  // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_