Issue 935663003: Fix compilation error on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 935663003: Fix compilation error on Windows. (Closed)

Created:
5 years, 10 months ago by halyavin2

Modified:
5 years, 10 months ago

Reviewers:
jam

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix compilation error on Windows. The build fails due to implicit double to integer conversion warning on width *= scale line and warnings being treated as errors. TEST= ninja BUG= none R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4351ac28111b7c74c397fee606260ced4de228b8

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	samples/pdfium_test.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download

Total messages: 9 (3 generated)

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

5 years, 10 months ago (2015-02-19 08:47:33 UTC) #6

jam

5 years, 10 months ago (2015-02-25 19:05:44 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4351ac28111b7c74c397fee606260ced4de228b8 (presubmit successful).