Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: sky/viewer/platform/platform_impl.cc

Issue 935633003: Don't depend on /net for error codes in sky viewer. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/viewer/platform/platform_impl.cc
diff --git a/sky/viewer/platform/platform_impl.cc b/sky/viewer/platform/platform_impl.cc
index c186858f7c157c1ce53e006e24eb161131555bbd..06a2d9cb38d8340fd9883dc298f975226f300b49 100644
--- a/sky/viewer/platform/platform_impl.cc
+++ b/sky/viewer/platform/platform_impl.cc
@@ -5,11 +5,19 @@
#include "sky/viewer/platform/platform_impl.h"
#include "mojo/public/cpp/application/application_impl.h"
-#include "net/base/net_errors.h"
#include "sky/viewer/platform/weburlloader_impl.h"
namespace sky {
+namespace {
+// This corresponds to ERR_ABORTED in net/base/net_error_list.h.
+// TODO(ppi): declare an enum in the network service mojom so that the clients
+// don't need to hard-code these values.
+const int32_t kNetErrorAborted = -3;
+
+const char kErrorDomain[] = "net";
+} // namespace
+
PlatformImpl::PlatformImpl(mojo::ApplicationImpl* app)
: main_thread_task_runner_(base::MessageLoop::current()->task_runner()) {
app->ConnectToService("mojo:network_service", &network_service_);
@@ -37,8 +45,8 @@ blink::WebURLLoader* PlatformImpl::createURLLoader() {
blink::WebURLError PlatformImpl::cancelledError(const blink::WebURL& url)
const {
blink::WebURLError error;
- error.domain = blink::WebString::fromUTF8(net::kErrorDomain);
- error.reason = net::ERR_ABORTED;
+ error.domain = blink::WebString::fromUTF8(kErrorDomain);
+ error.reason = kNetErrorAborted;
error.unreachableURL = url;
error.staleCopyInCache = false;
error.isCancellation = true;

Powered by Google App Engine
This is Rietveld 408576698