Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 935633003: Don't depend on /net for error codes in sky viewer. (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't depend on /net for error codes in sky viewer. This patch cuts the last dependencies of sky on /net by hardcoding the ERR_ABORTED status code. https://codereview.chromium.org/933973002/ is a proposed solution to avoid the hardcoding. BUG=456130 R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5502c24c03e945fd0085338626b736ed277b5b41

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Adam comment. #

Patch Set 3 : Address Adam comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M sky/viewer/BUILD.gn View 1 2 2 chunks +1 line, -1 line 0 comments Download
A sky/viewer/platform/net_constants.h View 1 1 chunk +16 lines, -0 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sky/viewer/platform/weburlloader_impl.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ppi
Hi Adam, Eric, wdyt?
5 years, 10 months ago (2015-02-17 17:55:28 UTC) #2
abarth-chromium
https://codereview.chromium.org/935633003/diff/1/sky/viewer/platform/weburlloader_impl.cc File sky/viewer/platform/weburlloader_impl.cc (right): https://codereview.chromium.org/935633003/diff/1/sky/viewer/platform/weburlloader_impl.cc#newcode27 sky/viewer/platform/weburlloader_impl.cc:27: const char kErrorDomain[] = "net"; Can we declare these ...
5 years, 10 months ago (2015-02-17 17:58:50 UTC) #3
ppi
Thanks, Adam. Ptal. https://codereview.chromium.org/935633003/diff/1/sky/viewer/platform/weburlloader_impl.cc File sky/viewer/platform/weburlloader_impl.cc (right): https://codereview.chromium.org/935633003/diff/1/sky/viewer/platform/weburlloader_impl.cc#newcode27 sky/viewer/platform/weburlloader_impl.cc:27: const char kErrorDomain[] = "net"; On ...
5 years, 10 months ago (2015-02-17 18:08:02 UTC) #4
abarth-chromium
LGTM Thanks!!!!!!!!!!!
5 years, 10 months ago (2015-02-17 18:16:10 UTC) #5
ppi
5 years, 10 months ago (2015-02-17 18:19:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5502c24c03e945fd0085338626b736ed277b5b41 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698