Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 935603002: Stop using HeapType in IC and Crankshaft (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stop using HeapType in IC and Crankshaft BUG= Committed: https://crrev.com/119cb5661724006b736fcb6484258c752125e372 Cr-Commit-Position: refs/heads/master@{#26696}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fixes #

Patch Set 4 : Ports #

Patch Set 5 : fix wrapping #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -531 lines) Patch
M src/accessors.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/accessors.cc View 2 chunks +6 lines, -23 lines 0 comments Download
M src/hydrogen.h View 1 2 3 4 5 6 chunks +15 lines, -13 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 35 chunks +115 lines, -131 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 2 3 6 chunks +9 lines, -11 lines 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 2 3 6 chunks +9 lines, -11 lines 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M src/ic/call-optimization.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/call-optimization.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ic/handler-compiler.h View 6 chunks +22 lines, -23 lines 0 comments Download
M src/ic/handler-compiler.cc View 15 chunks +21 lines, -27 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 3 6 chunks +10 lines, -11 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M src/ic/ic.h View 1 7 chunks +16 lines, -32 lines 0 comments Download
M src/ic/ic.cc View 26 chunks +77 lines, -133 lines 0 comments Download
M src/ic/ic-compiler.h View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 2 3 7 chunks +20 lines, -26 lines 0 comments Download
M src/ic/ic-inl.h View 3 chunks +13 lines, -13 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 6 chunks +9 lines, -11 lines 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M src/type-feedback-vector.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/type-feedback-vector.cc View 4 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-17 14:04:59 UTC) #2
Benedikt Meurer
Love it...LGTM
5 years, 10 months ago (2015-02-17 14:45:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935603002/100001
5 years, 10 months ago (2015-02-17 14:58:18 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-17 15:33:32 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 15:33:44 UTC) #7
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/119cb5661724006b736fcb6484258c752125e372
Cr-Commit-Position: refs/heads/master@{#26696}

Powered by Google App Engine
This is Rietveld 408576698