Prevent future app banners when app is added to the homescreen via menu

chrome/browser/android/shortcut_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/shortcut_helper.h"
 
 #include <jni.h>
 #include <limits>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/basictypes.h"
 #include "base/location.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "base/threading/worker_pool.h"
 #include "chrome/browser/android/manifest_icon_selector.h"
 #include "chrome/browser/android/tab_android.h"
+#include "chrome/browser/banners/app_banner_settings_helper.h"
 #include "chrome/browser/favicon/favicon_service.h"
 #include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/web_application_info.h"
 #include "components/dom_distiller/core/url_utils.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
@@ skipping 181 matching lines @@
     case MANIFEST_ICON_STATUS_DONE:
       AddShortcutUsingManifestIcon();
       break;
   }
 }
 
 void ShortcutHelper::AddShortcutUsingManifestIcon() {
   // Stop observing so we don't get destroyed while doing the last steps.
   Observe(NULL);
 
+  RecordAddToHomescreen();
+
   base::WorkerPool::PostTask(
       FROM_HERE,
       base::Bind(&ShortcutHelper::AddShortcutInBackgroundWithSkBitmap,
                  shortcut_info_,
                  manifest_icon_),
       true);
 
   Destroy();
 }
 
 void ShortcutHelper::AddShortcutUsingFavicon() {
+  RecordAddToHomescreen();

[gone, 2015/02/17 17:58:43]

The common point in the pathway for these is to go through
AddShortcutInBackgroundWithSkBitmap().  Just put a RecordAddToHomescreen there
and you should be good.

[benwells, 2015/02/17 19:49:53]

That's true but it is on the wrong thread. See
https://code.google.com/p/chromium/codesearch#chromium/src/components/content....

I could post a task from that common chokepoint back to the UI thread but that
felt a bit heavy.

[gone, 2015/02/17 19:52:08]

Hrm, fair point.

+
   Profile* profile =
       Profile::FromBrowserContext(web_contents()->GetBrowserContext());
 
   // Grab the best, largest icon we can find to represent this bookmark.
   // TODO(dfalcantara): Try combining with the new BookmarksHandler once its
   //                    rewrite is further along.
   std::vector<int> icon_types;
   icon_types.push_back(favicon_base::FAVICON);
   icon_types.push_back(favicon_base::TOUCH_PRECOMPOSED_ICON |
                        favicon_base::TOUCH_ICON);
@@ skipping 87 matching lines @@
       base::android::GetApplicationContext(),
       java_url.obj(),
       java_title.obj(),
       java_bitmap.obj(),
       r_value,
       g_value,
       b_value,
       info.display == content::Manifest::DISPLAY_MODE_STANDALONE,
       info.orientation);
 }
+
+void ShortcutHelper::RecordAddToHomescreen() {
+  // Record that the shortcut has been added, so no banners will be shown
+  // for this app.
+  AppBannerSettingsHelper::RecordBannerEvent(
+      web_contents(), shortcut_info_.url, shortcut_info_.url.spec(),
+      AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
+      base::Time::Now());
+}