App launcher: Spoken feedback reads out details of search results.

ui/app_list/views/search_result_view.h

Index: ui/app_list/views/search_result_view.h
diff --git a/ui/app_list/views/search_result_view.h b/ui/app_list/views/search_result_view.h
index f84f7af2d7e4a7d101899df48c803a2ea1d8ee20..86b8645cabaa24c6f80572f7a7d8c9e1a5c39e33 100644
--- a/ui/app_list/views/search_result_view.h
+++ b/ui/app_list/views/search_result_view.h
@@ -10,6 +10,7 @@
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/strings/string16.h"
 #include "ui/app_list/search_result_observer.h"
 #include "ui/app_list/views/search_result_actions_view_delegate.h"
 #include "ui/views/context_menu_controller.h"
@@ -37,11 +38,12 @@ class SearchResultViewDelegate;
 class SearchResultActionsView;
 
 // SearchResultView displays a SearchResult.
-class SearchResultView : public views::CustomButton,
-                         public views::ButtonListener,
-                         public views::ContextMenuController,
-                         public SearchResultObserver,
-                         public SearchResultActionsViewDelegate {
+class APP_LIST_EXPORT SearchResultView

[Matt Giuca, 2015/02/17 07:54:43]

This is needed for tests.

+    : public views::CustomButton,
+      public views::ButtonListener,
+      public views::ContextMenuController,
+      public SearchResultObserver,
+      public SearchResultActionsViewDelegate {
  public:
   // Internal class name.
   static const char kViewClassName[];
@@ -59,11 +61,15 @@ class SearchResultView : public views::CustomButton,
   // Clears the selected action.
   void ClearSelectedAction();
 
+  // Computes the button's spoken feedback name.
+  base::string16 ComputeAccessibleName() const;

[Matt Giuca, 2015/02/17 07:54:43]

This is also needed for tests.

Unfortunately, we cannot call Button::GetAccessibleName, because there is no
such thing. And we cannot call Button::GetAccessibleState, because it requires a
ui::AXViewState, and its constructor is in a separate DLL which is not linked
into the tests! Aarrghh!

So I just provide this separate method for tests to find out what the accessible
name will be.

[calamity, 2015/02/18 03:57:33]

lol.

+
  private:
   friend class app_list::test::SearchResultListViewTest;
 
   void UpdateTitleText();
   void UpdateDetailsText();
+  void UpdateAccessibleName();
 
   // views::View overrides:
   const char* GetClassName() const override;