Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 935423002: Avoid shadowing local |event| in CueTimeline::updateActiveCues (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid shadowing local |event| in CueTimeline::updateActiveCues Dispatching to the track element would declare an |event| in its scope that would shadow an |event| in the parent scope. Avoid this by moving the event-creation-for-a-target to a small helper function and then use that for all scheduling of events in this method. BUG=321654 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -23 lines) Patch
M Source/core/html/track/CueTimeline.cpp View 3 chunks +14 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 10 months ago (2015-02-19 16:28:05 UTC) #2
philipj_slow
lgtm, but s/it's/its/ in description
5 years, 10 months ago (2015-02-19 17:36:14 UTC) #3
fs
On 2015/02/19 17:36:14, philipj_UTC7 wrote: > lgtm, but s/it's/its/ in description Fixed.
5 years, 10 months ago (2015-02-20 08:28:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935423002/1
5 years, 10 months ago (2015-02-20 08:29:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 08:32:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190543

Powered by Google App Engine
This is Rietveld 408576698