Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2289)

Unified Diff: content/shell/android/shell_library_loader.cc

Issue 935413004: Separate OnJNIOnLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/android/shell_library_loader.cc
diff --git a/content/shell/android/shell_library_loader.cc b/content/shell/android/shell_library_loader.cc
index 6d80fc3a85cb97b2c09843d0b28f48cdb091ecf9..5bcd539ab4348987e25823022d2f493c987a2c42 100644
--- a/content/shell/android/shell_library_loader.cc
+++ b/content/shell/android/shell_library_loader.cc
@@ -3,7 +3,7 @@
// found in the LICENSE file.
#include "base/android/jni_android.h"
-#include "base/android/jni_onload_delegate.h"
+#include "base/bind.h"
#include "content/public/app/content_jni_onload.h"
#include "content/public/app/content_main.h"
#include "content/public/browser/android/compositor.h"
@@ -12,17 +12,11 @@
namespace {
-class ShellJNIOnLoadDelegate : public base::android::JNIOnLoadDelegate {
- public:
- bool RegisterJNI(JNIEnv* env) override;
- bool Init() override;
-};
-
-bool ShellJNIOnLoadDelegate::RegisterJNI(JNIEnv* env) {
+bool RegisterJNI(JNIEnv* env) {
return content::android::RegisterShellJni(env);
}
-bool ShellJNIOnLoadDelegate::Init() {
+bool Init() {
content::Compositor::Initialize();
content::SetContentMainDelegate(new content::ShellMainDelegate());
return true;
@@ -33,8 +27,9 @@ bool ShellJNIOnLoadDelegate::Init() {
// This is called by the VM when the shared library is first loaded.
JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
- ShellJNIOnLoadDelegate delegate;
- if (!content::android::OnJNIOnLoad(vm, &delegate))
+ if (!content::android::OnJNIOnLoadRegisterJNI(
+ vm, base::Bind(&RegisterJNI)) ||
+ !content::android::OnJNIOnLoadInit(base::Bind(&Init)))
return -1;
return JNI_VERSION_1_4;
« no previous file with comments | « content/shell/android/linker_test_apk/chromium_linker_test_android.cc ('k') | testing/android/native_test_jni_onload.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698