Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 935413003: Pass Isolate* more explicitly in Parser, with less reliance on info->isolate(). (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
Reviewers:
marja
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass Isolate* more explicitly in Parser, with less reliance on info->isolate(). R=marja@chromium.org BUG= Committed: https://crrev.com/726f3801a4ca7371ddcd1f0193331242da8cee18 Cr-Commit-Position: refs/heads/master@{#26765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -34 lines) Patch
M src/api.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/parser.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/parser.cc View 11 chunks +25 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 10 months ago (2015-02-19 17:22:31 UTC) #1
marja
lgtm
5 years, 10 months ago (2015-02-20 09:06:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935413003/1
5 years, 10 months ago (2015-02-20 09:18:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 09:39:36 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 09:39:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/726f3801a4ca7371ddcd1f0193331242da8cee18
Cr-Commit-Position: refs/heads/master@{#26765}

Powered by Google App Engine
This is Rietveld 408576698