Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 935333003: Fix a bug that generic thumbnail is visible behind transparent thumbnail. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug that generic thumbnail is visible behind transparent thumbnail. BUG=459326 TEST=open a folder which contains transparent image and confirm that generic thumbnail is not visible behind thumbnail. Committed: https://crrev.com/1d7c9bcbdbce27fc656fda9364e00bf512795e49 Cr-Commit-Position: refs/heads/master@{#317033}

Patch Set 1 #

Patch Set 2 : Set background-color directly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-19 12:02:11 UTC) #2
yawano
As we talked offline, I created a new patch to set background-color directly. This could ...
5 years, 10 months ago (2015-02-19 12:24:39 UTC) #3
fukino
On 2015/02/19 12:24:39, yawano wrote: > As we talked offline, I created a new patch ...
5 years, 10 months ago (2015-02-19 12:25:28 UTC) #4
yawano
On 2015/02/19 12:25:28, fukino wrote: > On 2015/02/19 12:24:39, yawano wrote: > > As we ...
5 years, 10 months ago (2015-02-19 12:25:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935333003/20001
5 years, 10 months ago (2015-02-19 12:27:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 12:45:25 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 12:46:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d7c9bcbdbce27fc656fda9364e00bf512795e49
Cr-Commit-Position: refs/heads/master@{#317033}

Powered by Google App Engine
This is Rietveld 408576698