third_party/harfbuzz-ng/src/hb-ot-shape.cc - Issue 935333002: Update from https://crrev.com/316786

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz-ng/src/hb-ot-shape.cc

Issue 935333002: Update from https://crrev.com/316786 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/harfbuzz-ng/src/hb-ot-shape.cc

diff --git a/third_party/harfbuzz-ng/src/hb-ot-shape.cc b/third_party/harfbuzz-ng/src/hb-ot-shape.cc

index a0b503ab0f23f95b26988acd3f1334dc63a5665d..07adb04f678c8ae39eb015292aa45e9ca6c991ab 100644

--- a/third_party/harfbuzz-ng/src/hb-ot-shape.cc

+++ b/third_party/harfbuzz-ng/src/hb-ot-shape.cc

@@ -676,7 +676,7 @@ hb_ot_hide_default_ignorables (hb_ot_shape_context_t *c)

pos[i].y_advance = 0;

}

else

- continue; /* Delete it. */

+ continue; /* Delete it. XXX Merge clusters? */

}

if (j != i)

{