Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: net/quic/quic_crypto_client_stream.cc

Issue 935333002: Update from https://crrev.com/316786 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_crypto_client_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_crypto_client_stream.cc
diff --git a/net/quic/quic_crypto_client_stream.cc b/net/quic/quic_crypto_client_stream.cc
index 26bd17170f7861e2a10c88151516335aa3abccdf..c7c0291aecc5174b8192cc50194e4e833a465242 100644
--- a/net/quic/quic_crypto_client_stream.cc
+++ b/net/quic/quic_crypto_client_stream.cc
@@ -87,7 +87,9 @@ QuicCryptoClientStream::QuicCryptoClientStream(
channel_id_source_callback_run_(false),
channel_id_source_callback_(nullptr),
verify_context_(verify_context),
- proof_verify_callback_(nullptr) {}
+ proof_verify_callback_(nullptr) {
+ DCHECK(!session->connection()->is_server());
+}
QuicCryptoClientStream::~QuicCryptoClientStream() {
if (channel_id_source_callback_) {
@@ -196,7 +198,7 @@ void QuicCryptoClientStream::DoHandshakeLoop(
break;
case STATE_SEND_CHLO:
DoSendCHLO(in, cached);
- return;
+ return; // return waiting to hear from server.
case STATE_RECV_REJ:
DoReceiveREJ(in, cached);
break;
@@ -638,7 +640,7 @@ bool QuicCryptoClientStream::RequiresChannelID(
return false;
}
const CryptoHandshakeMessage* scfg = cached->GetServerConfig();
- if (!scfg) { // scfg may be null when we send an inchoate CHLO.
+ if (!scfg) { // scfg may be null then we send an inchoate CHLO.
return false;
}
const QuicTag* their_proof_demands;
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_crypto_client_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698