Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: net/quic/quic_ack_notifier_manager.h

Issue 935333002: Update from https://crrev.com/316786 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_ack_notifier.cc ('k') | net/quic/quic_ack_notifier_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_ack_notifier_manager.h
diff --git a/net/quic/quic_ack_notifier_manager.h b/net/quic/quic_ack_notifier_manager.h
index bf4d574f2431d62cb74a2db7e1debd617ae43fbf..d4d97ad7cd75f41bbe9ab4dd88f62192018ab152 100644
--- a/net/quic/quic_ack_notifier_manager.h
+++ b/net/quic/quic_ack_notifier_manager.h
@@ -48,22 +48,14 @@ class NET_EXPORT_PRIVATE AckNotifierManager {
private:
typedef std::list<QuicAckNotifier*> AckNotifierList;
- typedef base::hash_set<QuicAckNotifier*> AckNotifierSet;
// TODO(ianswett): Further improvement may come from changing this to a deque.
typedef base::hash_map<QuicPacketSequenceNumber, AckNotifierList>
AckNotifierMap;
- // On every ACK frame received by the connection, all the ack_notifiers_ will
- // be told which sequeunce numbers were ACKed.
- // Once a given QuicAckNotifier has seen all the sequence numbers it is
- // interested in, it will be deleted, and removed from this set.
- // Owns the AckNotifiers in this set.
- AckNotifierSet ack_notifiers_;
-
// Maps from sequence number to the AckNotifiers which are registered
// for that sequence number. On receipt of an ACK for a given sequence
// number, call OnAck for all mapped AckNotifiers.
- // Does not own the AckNotifiers.
+ // When the last reference is removed from the map, the notifier is deleted.
AckNotifierMap ack_notifier_map_;
DISALLOW_COPY_AND_ASSIGN(AckNotifierManager);
« no previous file with comments | « net/quic/quic_ack_notifier.cc ('k') | net/quic/quic_ack_notifier_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698