Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 935303002: [Smart Lock] Measure clicks on the lock icon during Easy Unlock's trial run. (Closed)

Created:
5 years, 10 months ago by Ilya Sherman
Modified:
5 years, 10 months ago
Reviewers:
Nikita (slow), Tim Song
CC:
chromium-reviews, oshima+watch_chromium.org, dzhioev+watch_chromium.org, asvitkine+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Measure clicks on the lock icon during Easy Unlock's trial run. BUG=450508 TEST=none R=nkostylev@chromium.org, tengs@chromium.org Committed: https://crrev.com/8afaf6188bfdbe912f815f344b7fd8752efff74d Cr-Commit-Position: refs/heads/master@{#317283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -11 lines) Patch
M chrome/browser/chromeos/login/screens/user_selection_screen.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/models/user_board_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_metrics.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_metrics.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.cc View 5 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc View 2 chunks +26 lines, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/signin/screenlock_bridge.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/signin/screenlock_bridge.cc View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +22 lines, -0 lines 0 comments Download
M ui/login/account_picker/screen_account_picker.js View 1 chunk +1 line, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Ilya Sherman
Nikita, PTAL at everything outside of //chrome/browser/signin. Tim, PTAL at everything, but especially //chrome/browser/signin.
5 years, 10 months ago (2015-02-19 07:05:16 UTC) #1
Nikita (slow)
On 2015/02/19 07:05:16, Ilya Sherman wrote: > Nikita, PTAL at everything outside of //chrome/browser/signin. lgtm
5 years, 10 months ago (2015-02-19 14:26:20 UTC) #2
Tim Song
lgtm
5 years, 10 months ago (2015-02-20 08:36:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935303002/1
5 years, 10 months ago (2015-02-20 08:37:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 11:06:31 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 11:07:35 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8afaf6188bfdbe912f815f344b7fd8752efff74d
Cr-Commit-Position: refs/heads/master@{#317283}

Powered by Google App Engine
This is Rietveld 408576698