Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 935293002: Launcher Search box, Back and Mic buttons now focusable in ChromeVox. (Closed)

Created:
5 years, 10 months ago by Matt Giuca
Modified:
5 years, 10 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@tileitemview-setselected
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Launcher Search box, Back and Mic buttons now focusable in ChromeVox. Back and Mic buttons now have accessible names. Also added a tooltip to Back button. Added some special logic to avoid focusing the Search box in the search results page (because of the dual focus; it is more important to read out the result than the search box). BUG=458885, 459859 Committed: https://crrev.com/6213d0961fc7dfe97873706342ff67107d74494c Cr-Commit-Position: refs/heads/master@{#317287}

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 2

Patch Set 3 : Avoid using ContentsView (fix tests). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -8 lines) Patch
M chrome/browser/ui/app_list/search/search_resource_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/app_list/search_box_model.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/app_list/search_box_model.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/app_list/views/search_box_view.cc View 1 2 5 chunks +30 lines, -4 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Matt Giuca
5 years, 10 months ago (2015-02-19 06:55:57 UTC) #3
calamity
https://codereview.chromium.org/935293002/diff/40001/ui/app_list/views/search_box_view.h File ui/app_list/views/search_box_view.h (right): https://codereview.chromium.org/935293002/diff/40001/ui/app_list/views/search_box_view.h#newcode74 ui/app_list/views/search_box_view.h:74: void set_contents_view(ContentsView* contents_view) { This will break tests.
5 years, 10 months ago (2015-02-20 03:45:25 UTC) #4
Matt Giuca
https://codereview.chromium.org/935293002/diff/40001/ui/app_list/views/search_box_view.h File ui/app_list/views/search_box_view.h (right): https://codereview.chromium.org/935293002/diff/40001/ui/app_list/views/search_box_view.h#newcode74 ui/app_list/views/search_box_view.h:74: void set_contents_view(ContentsView* contents_view) { Fixed. (As discussed, we just ...
5 years, 10 months ago (2015-02-20 05:15:17 UTC) #5
calamity
lgtm
5 years, 10 months ago (2015-02-20 05:51:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935293002/60001
5 years, 10 months ago (2015-02-20 06:07:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935293002/60001
5 years, 10 months ago (2015-02-20 08:17:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935293002/60001
5 years, 10 months ago (2015-02-20 10:57:12 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-02-20 11:12:47 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 11:13:13 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6213d0961fc7dfe97873706342ff67107d74494c
Cr-Commit-Position: refs/heads/master@{#317287}

Powered by Google App Engine
This is Rietveld 408576698