Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 935243003: Turn on job based recompilation (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn on job based recompilation BUG=v8:3608 R=yangguo@chromium.org LOG=y Committed: https://crrev.com/4ae82f64b09cdc0182cee3a5cc619a9117ac5fbc Cr-Commit-Position: refs/heads/master@{#26826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
jochen (gone - plz use gerrit)
5 years, 10 months ago (2015-02-24 10:47:39 UTC) #1
Yang
On 2015/02/24 10:47:39, jochen (slow) wrote: lgtm.
5 years, 10 months ago (2015-02-24 10:50:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935243003/1
5 years, 10 months ago (2015-02-24 10:53:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/191)
5 years, 10 months ago (2015-02-24 11:05:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935243003/1
5 years, 10 months ago (2015-02-24 15:03:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 15:20:23 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ae82f64b09cdc0182cee3a5cc619a9117ac5fbc Cr-Commit-Position: refs/heads/master@{#26826}
5 years, 10 months ago (2015-02-24 15:20:42 UTC) #10
jochen (gone - plz use gerrit)
5 years, 10 months ago (2015-02-24 15:47:04 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/937263004/ by jochen@chromium.org.

The reason for reverting is: waterfall disagrees.

Powered by Google App Engine
This is Rietveld 408576698