tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index bc94c61a0695ada9ac474e49eb17826e54ce7075..6760bbac8af1e1d3d0f6d2becc4ef58332d392eb 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -6425,6 +6425,46 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="EasyUnlock.AuthSuccessRemoteDeviceModelHash">

[Ilya Sherman, 2015/02/19 08:01:28]

By the way, I've been trying to group new, related histograms in subcategories,
e.g. EasyUnlock.Setup.*.  I think it would be nice to do the same for these --
e.g. EasyUnlock.AuthSuccess.* (extra dot after "success") or
EasyUnlock.ProximityHeuristics.AuthSuccess.*.

[Tim Song, 2015/02/19 23:33:31]

Done. I put them under the EasyUnlock.AuthProximity group.

+  <owner>tengs@google.com</owner>
+  <owner>xiaowenx@google.com</owner>

[Ilya Sherman, 2015/02/19 07:20:58]

nit: Please use @chromium.org throughout.

[Tim Song, 2015/02/19 23:33:31]

Done.

+  <summary>
+    The hash of the phone model used to successfully sign in or unlock using
+    Smart Lock.
+  </summary>
+</histogram>

[Ilya Sherman, 2015/02/19 07:20:58]

Please associate an enum with at least some of the common models that we expect
to see.

[Tim Song, 2015/02/19 23:33:31]

Done.

+
+<histogram name="EasyUnlock.AuthSuccessRollingRssi" units="dB">
+  <owner>tengs@google.com</owner>
+  <owner>xiaowenx@google.com</owner>
+  <summary>
+    Measures the exponentially weighted rolling average of the received signal
+    strength indicator (RSSI) of the phone when the user successfully unlocks or
+    signs in using Smart Lock. The averaging formula is subject to change.
+  </summary>
+</histogram>
+
+<histogram name="EasyUnlock.AuthSuccessTimeSinceLastZeroRssi"
+    units="milliseconds">
+  <owner>tengs@google.com</owner>
+  <owner>xiaowenx@google.com</owner>
+  <summary>
+    Measures the time delta in milliseconds since the last zero RSSI value was
+    read to when the user successfully unlocks or signs in using Smart Lock. A
+    zero RSSI value is special as that is the strength that Bluetooth devices
+    attempt to maintain by adjusting their transmit power levels.

[Ilya Sherman, 2015/02/19 07:20:58]

Please document what is recorded in the case that there was no zero RSSI value
recorded.

[Tim Song, 2015/02/19 23:33:31]

Done.

+  </summary>
+</histogram>
+
+<histogram name="EasyUnlock.AuthSuccessTransmitPower" units="dB">
+  <owner>tengs@google.com</owner>
+  <owner>xiaowenx@google.com</owner>
+  <summary>
+    Measures the current transmit power of the local device when the user
+    successfully unlocks or signs in using Smart Lock.

[Ilya Sherman, 2015/02/19 07:20:58]

We should probably measure a difference between the current transmit power and
the max, since the max varies by hardware model.

[Tim Song, 2015/02/19 23:33:31]

Done.

+  </summary>
+</histogram>
+
 <histogram name="EasyUnlock.ClickedButton" enum="EasyUnlockButton">
   <owner>joshwoodward@google.com</owner>
   <owner>tbarzic@chromium.org</owner>