cc: Fix missing render surfaces with output requests

cc: Fix missing render surfaces with output requests

The main thread calculates needed render surfaces, but doesn't have all
of the information that it needs.  In particular, it may not know that
one of its twin layers on the pending or active tree still has an
unserviced copy output request that will live through the commit and
activation, and thus that twin will still need a render surface.

As render surface calculations will probably move to the compositor
thread, rather than adding in complicated tracking and counting of
outstanding copy requests to Layer and request callbacks, instead
just add some logic to check if there are remaining copy output requests
during commit and activation and take that into consideration when
setting the output surface.

This also reverts commit 1e447ad6426b03803cf6cf091ffc8edede265e71,
which was clearly legit as it caught this mistake.

BUG=457217
Committed: https://crrev.com/b723b4e24b5160aee2db354084b7ccc6a709fbec
Cr-Commit-Position: refs/heads/master@{#317107}

[enne (OOO), 2015-02-19 01:50:58]

enne@chromium.org changed reviewers:
+ danakj@chromium.org, vollick@chromium.org

[danakj, 2015-02-19 18:08:40]

LGTM

https://codereview.chromium.org/935193002/diff/1/cc/trees/layer_tree_host_uni...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/935193002/diff/1/cc/trees/layer_tree_host_uni...
cc/trees/layer_tree_host_unittest.cc:6354: ASSERT_TRUE(child_impl);
ASSERT_ in layer tree tests is marginally bleh cuz it just makes the test time
out instead of end immediately with a crash

[enne (OOO), 2015-02-19 18:10:31]

https://codereview.chromium.org/935193002/diff/1/cc/trees/layer_tree_host_uni...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/935193002/diff/1/cc/trees/layer_tree_host_uni...
cc/trees/layer_tree_host_unittest.cc:6354: ASSERT_TRUE(child_impl);
On 2015/02/19 18:08:39, danakj wrote:
> ASSERT_ in layer tree tests is marginally bleh cuz it just makes the test time
> out instead of end immediately with a crash

But crashing in a unit test ends everything?

[enne (OOO), 2015-02-19 18:11:19]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2015-02-19 18:13:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935193002/1

[danakj, 2015-02-19 18:36:44]

https://codereview.chromium.org/935193002/diff/1/cc/trees/layer_tree_host_uni...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/935193002/diff/1/cc/trees/layer_tree_host_uni...
cc/trees/layer_tree_host_unittest.cc:6354: ASSERT_TRUE(child_impl);
On 2015/02/19 18:10:31, enne wrote:
> On 2015/02/19 18:08:39, danakj wrote:
> > ASSERT_ in layer tree tests is marginally bleh cuz it just makes the test
time
> > out instead of end immediately with a crash
> 
> But crashing in a unit test ends everything?

Not sure what you mean, it ends the test immediately but not other tests (with
test launcher)?

[enne (OOO), 2015-02-19 18:39:09]

The CQ bit was unchecked by enne@chromium.org

[enne (OOO), 2015-02-19 18:40:24]

New patchsets have been uploaded after l-g-t-m from danakj@chromium.org

[enne (OOO), 2015-02-19 18:40:25]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2015-02-19 18:40:33]

https://codereview.chromium.org/935193002/diff/1/cc/trees/layer_tree_host_uni...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/935193002/diff/1/cc/trees/layer_tree_host_uni...
cc/trees/layer_tree_host_unittest.cc:6354: ASSERT_TRUE(child_impl);
On 2015/02/19 18:36:44, danakj wrote:
> On 2015/02/19 18:10:31, enne wrote:
> > On 2015/02/19 18:08:39, danakj wrote:
> > > ASSERT_ in layer tree tests is marginally bleh cuz it just makes the test
> time
> > > out instead of end immediately with a crash
> > 
> > But crashing in a unit test ends everything?
> 
> Not sure what you mean, it ends the test immediately but not other tests (with
> test launcher)?

Ok.  Removed asserts.

[commit-bot: I haz the power, 2015-02-19 18:41:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935193002/20001

[commit-bot: I haz the power, 2015-02-19 19:47:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-19 19:48:32]

Patchset 2 (id:??) landed as
https://crrev.com/b723b4e24b5160aee2db354084b7ccc6a709fbec
Cr-Commit-Position: refs/heads/master@{#317107}