Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 935143005: TileItemView: Fixed ChromeVox selection upon deselection. (Closed)

Created:
5 years, 10 months ago by Matt Giuca
Modified:
5 years, 10 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@glevin-ares-tabstops
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TileItemView: Fixed ChromeVox selection upon deselection. BUG=459872 Committed: https://crrev.com/d26db64204779a107a0adbab6721e73c63da4579 Cr-Commit-Position: refs/heads/master@{#317018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/app_list/views/tile_item_view.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Matt Giuca
5 years, 10 months ago (2015-02-19 06:35:54 UTC) #2
calamity
lgtm
5 years, 10 months ago (2015-02-19 06:55:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935143005/1
5 years, 10 months ago (2015-02-19 06:56:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/44085)
5 years, 10 months ago (2015-02-19 07:08:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935143005/1
5 years, 10 months ago (2015-02-19 08:41:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 09:13:41 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 09:14:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d26db64204779a107a0adbab6721e73c63da4579
Cr-Commit-Position: refs/heads/master@{#317018}

Powered by Google App Engine
This is Rietveld 408576698