Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3556)

Unified Diff: cc/trees/layer_tree_impl.cc

Issue 935143002: cc: Remove UpdateDrawProperties during sync composite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lcd_text_compositor_side_only
Patch Set: I can't type today Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/layer_tree_pixel_test.cc ('k') | cc/trees/single_thread_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_impl.cc
diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc
index 8274f00c98a170e1e429deea801bbd98772df5e0..0b865cc72c9225bddd0897b20e8177e9b4399630 100644
--- a/cc/trees/layer_tree_impl.cc
+++ b/cc/trees/layer_tree_impl.cc
@@ -538,16 +538,23 @@ bool LayerTreeImpl::UpdateDrawProperties(bool update_lcd_text) {
if (!needs_update_draw_properties_)
return true;
- // For max_texture_size.
+ // Calling UpdateDrawProperties must clear this flag, so there can be no
+ // early outs before this.
+ needs_update_draw_properties_ = false;
+
+ // For max_texture_size. When the renderer is re-created in
+ // CreateAndSetRenderer, the needs update draw properties flag is set
+ // again.
if (!layer_tree_host_impl_->renderer())
return false;
+ // Clear this after the renderer early out, as it should still be
+ // possible to hit test even without a renderer.
+ render_surface_layer_list_.clear();
+
if (!root_layer())
return false;
- needs_update_draw_properties_ = false;
- render_surface_layer_list_.clear();
-
{
TRACE_EVENT2(
"cc", "LayerTreeImpl::UpdateDrawProperties::CalculateDrawProperties",
« no previous file with comments | « cc/test/layer_tree_pixel_test.cc ('k') | cc/trees/single_thread_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698