cc: Remove UpdateDrawProperties during sync composite

cc: Remove UpdateDrawProperties during sync composite

This is redundant with the UpdateDrawProperties that happens during
CommitComplete.  One pixel test was amusingly changing draw properties
after the commit and update, so modify it to do the update earlier.

Committed: https://crrev.com/0acea6ae7fc5cd07bcf05b6ec1443ba66557880e
Cr-Commit-Position: refs/heads/master@{#317115}

[enne (OOO), 2015-02-18 23:41:11]

enne@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-02-18 23:49:55]

LGTM

https://codereview.chromium.org/935143002/diff/1/cc/test/layer_tree_pixel_tes...
File cc/test/layer_tree_pixel_test.cc (right):

https://codereview.chromium.org/935143002/diff/1/cc/test/layer_tree_pixel_tes...
cc/test/layer_tree_pixel_test.cc:68: impl->pending_tree() ? impl->pending_tree()
: impl->active_tree();
can this use sync_tree()?

[enne (OOO), 2015-02-18 23:59:24]

New patchsets have been uploaded after l-g-t-m from danakj@chromium.org

[enne (OOO), 2015-02-18 23:59:27]

https://codereview.chromium.org/935143002/diff/1/cc/test/layer_tree_pixel_tes...
File cc/test/layer_tree_pixel_test.cc (right):

https://codereview.chromium.org/935143002/diff/1/cc/test/layer_tree_pixel_tes...
cc/test/layer_tree_pixel_test.cc:68: impl->pending_tree() ? impl->pending_tree()
: impl->active_tree();
On 2015/02/18 at 23:49:55, danakj wrote:
> can this use sync_tree()?

Done.

[enne (OOO), 2015-02-19 01:32:01]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2015-02-19 01:33:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935143002/20001

[commit-bot: I haz the power, 2015-02-19 02:28:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-19 02:28:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[enne (OOO), 2015-02-19 02:54:05]

Failure is legit.  Apparently UDP doesn't always unset the needs UDP flag due to
some early outs, so the DCHECK isn't legit unless I change those too.  I'll take
a look and see if I can change that.

[enne (OOO), 2015-02-19 18:54:08]

Rearrange the early outs in UpdateDrawProperties.  Could you take another quick
look and let me know what you think?

[danakj, 2015-02-19 19:03:30]

LGTM

https://codereview.chromium.org/935143002/diff/60001/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/935143002/diff/60001/cc/trees/layer_tree_impl...
cc/trees/layer_tree_impl.cc:547: // agian.
again

[enne (OOO), 2015-02-19 19:05:46]

New patchsets have been uploaded after l-g-t-m from danakj@chromium.org

[enne (OOO), 2015-02-19 19:05:48]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2015-02-19 19:07:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935143002/80001

[commit-bot: I haz the power, 2015-02-19 20:02:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-19 20:02:54]

Patchset 5 (id:??) landed as
https://crrev.com/0acea6ae7fc5cd07bcf05b6ec1443ba66557880e
Cr-Commit-Position: refs/heads/master@{#317115}