Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 935133002: Add hook for sdkextras, clean out stale entries (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
Reviewers:
alhaad
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add hook for sdkextras, clean out stale entries We need to run the sdkextras hook to download the google play services jar on the buildbots. Developers should run build/install-build-deps-android.sh manually to review the license terms. Also removes some stale hooks: - install-arm-sysroot does nothing - we don't need a win_toolchain as we don't build on windows. R=alhaad@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/138597c0ab2cdbcee0e43dd14c2d313171f20c6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M DEPS View 2 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
5 years, 10 months ago (2015-02-18 23:35:23 UTC) #1
alhaad
lgtm.
5 years, 10 months ago (2015-02-19 00:09:00 UTC) #3
jamesr
5 years, 10 months ago (2015-02-19 00:10:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
138597c0ab2cdbcee0e43dd14c2d313171f20c6e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698