Allow re-enabling of DISABLE_NOT_VERIFIED extensions if appropriate

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 1a757c0addebbda276163a8f9207ae56f8235731..3ad44b49792482399f72d173d540a97b6fd0f92e 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -172,7 +172,8 @@ ExtensionSettingsHandler::ExtensionSettingsHandler(ExtensionService* service,
       deleting_rph_id_(-1),
       registered_for_notifications_(false),
       warning_service_observer_(this),
-      error_console_observer_(this) {
+      error_console_observer_(this),
+      should_do_verification_check_(false) {
 }
 
 // static
@@ -198,6 +199,8 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
   bool suspicious_install =
       (disable_reasons & Extension::DISABLE_NOT_VERIFIED) != 0;
   extension_data->SetBoolean("suspiciousInstall", suspicious_install);
+  if (suspicious_install)
+    should_do_verification_check_ = true;
 
   bool managed_install =
       !management_policy_->UserMayModifySettings(extension, NULL);
@@ -731,6 +734,10 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(
       "extensions.ExtensionSettings.returnExtensionsData", results);
 
   MaybeRegisterForNotifications();
+  if (should_do_verification_check_) {
+    should_do_verification_check_ = false;
+    extension_service_->VerifyAllExtensions();
+  }

[Finnur, 2013/12/16 14:21:51]

Does this result in HandleRequestExtensionsData getting called again? Or how
does the status change of an extension get reflected? Does the user have to
refresh the page to see the change?

[asargent_no_longer_on_chrome, 2013/12/16 18:47:10]

VerifyAllExtensions will post a task to talk to the server, and that comes back
asynchronously to be handled in ExtensionService::FinishVerifyAllExtensions.
Inside there, if any extensions that are currently disabled with
DISABLE_NOT_VERIFIED actually could be verified, then I send the
NOTIFICATION_EXTENSION_UNLOADED notification which will cause this object to
notice the change and make it possible for the user to enable the item again.
(without them having to manually refresh the page)
 

 }
 
 void ExtensionSettingsHandler::HandleToggleDeveloperMode(