Allow re-enabling of DISABLE_NOT_VERIFIED extensions if appropriate

chrome/browser/resources/extensions/extension_list.js

Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index dbdf94b339721e0978ef7f46f24f27d682dcbb49..47eb86b93029d9be634e661b2d4a787f9a8b68f6 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -88,8 +88,6 @@ cr.define('options', function() {
       if (extension.managedInstall) {
         node.classList.add('may-not-modify');
         node.classList.add('may-not-remove');
-      } else if (extension.suspiciousInstall) {
-        node.classList.add('may-not-modify');

[Finnur, 2013/12/11 17:28:20]

Wait... why is this necessary? Doesn't it undo what I did for the
chrome://extensions page (prevent the user from enabling)?

[asargent_no_longer_on_chrome, 2013/12/11 21:26:05]

The problem is that if for some reason we got the wrong answer from the
verification check (say the server was down or had a momentary hiccup) and an
extension ends up in the DISABLE_NOT_VERIFIED state, there isn't any way for the
user to ever force the system to retry. Their only option would be to uninstall
and reinstall, but this could lose saved state that they care about. 

With the changes in this CL, if they click the enable checkbox, we'll go off and
do another verification check, and if that succeeds the extension will be
re-enabled. It might be nice to eventually show some sort of spinner or
something, but for now I wanted to at least make this possible. 

[Finnur, 2013/12/11 21:46:31]

OK. For anyone reading at home we had a hangout where we discussed asking Sriram
if he has any good ideas on how to improve the UX of failing to disable an
extension (because it hasn't been migrated).

       }
 
       var idToHighlight = this.getIdQueryParam_();
@@ -206,10 +204,9 @@ cr.define('options', function() {
         // The 'Enabled' checkbox.
         var enable = node.querySelector('.enable-checkbox');
         enable.hidden = false;
-        enable.querySelector('input').disabled = extension.managedInstall ||
-                                                 extension.suspiciousInstall;
+        enable.querySelector('input').disabled = extension.managedInstall;
 
-        if (!extension.managedInstall && !extension.suspiciousInstall) {
+        if (!extension.managedInstall) {
           enable.addEventListener('click', function(e) {
             // When e.target is the label instead of the checkbox, it doesn't
             // have the checked property and the state of the checkbox is