Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6558)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 93513006: Allow re-enabling of DISABLE_NOT_VERIFIED extensions if appropriate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix a few nits Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 1a757c0addebbda276163a8f9207ae56f8235731..3ad44b49792482399f72d173d540a97b6fd0f92e 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -172,7 +172,8 @@ ExtensionSettingsHandler::ExtensionSettingsHandler(ExtensionService* service,
deleting_rph_id_(-1),
registered_for_notifications_(false),
warning_service_observer_(this),
- error_console_observer_(this) {
+ error_console_observer_(this),
+ should_do_verification_check_(false) {
}
// static
@@ -198,6 +199,8 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
bool suspicious_install =
(disable_reasons & Extension::DISABLE_NOT_VERIFIED) != 0;
extension_data->SetBoolean("suspiciousInstall", suspicious_install);
+ if (suspicious_install)
+ should_do_verification_check_ = true;
bool managed_install =
!management_policy_->UserMayModifySettings(extension, NULL);
@@ -731,6 +734,10 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(
"extensions.ExtensionSettings.returnExtensionsData", results);
MaybeRegisterForNotifications();
+ if (should_do_verification_check_) {
+ should_do_verification_check_ = false;
+ extension_service_->VerifyAllExtensions();
+ }
}
void ExtensionSettingsHandler::HandleToggleDeveloperMode(
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698