Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: sky/specs/script.md

Issue 935113002: Specs: add that we assume library.declarations to be in source order to the list of (currently unwa… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/specs/script.md
diff --git a/sky/specs/script.md b/sky/specs/script.md
index 15c4dba252f571850777b766427bcc25d540d856..6bb5c28cc26b063d4455fb4ad95f02b77059f81a 100644
--- a/sky/specs/script.md
+++ b/sky/specs/script.md
@@ -27,7 +27,7 @@ abstract class AutomaticMetadata {
void init(DeclarationMirror target, Module module);
static void runLibrary(LibraryMirror library, Module module) {
- library.declarations.values.toList()..sort((DeclarationMirror a, DeclarationMirror b) {
+ library.declarations.values.toList() /* ..sort((DeclarationMirror a, DeclarationMirror b) {
bool aHasLocation;
try {
aHasLocation = a.location != null;
@@ -49,7 +49,7 @@ abstract class AutomaticMetadata {
if (a.location.line != b.location.line)
return a.location.line - b.location.line;
return a.location.column - b.location.column;
- })
+ }) */
..forEach((DeclarationMirror d) {
d.metadata.forEach((InstanceMirror i) {
if (i.reflectee is AutomaticMetadata)
@@ -93,3 +93,6 @@ assumed to exist:
ClassName = SuperclassName;
ClassName.namedConstructor = SuperclassName.otherNamedConstructor;
```
+
+* The reflection APIs (`dart:mirrors`) are assumed to reflect a
+ library's declarations in source order.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698