[PresentationAPI] Implementing start/joinSession from WebPresentationClient to PresentationService.

content/renderer/presentation/presentation_dispatcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/presentation/presentation_dispatcher.h"
 
 #include "content/common/presentation/presentation_service.mojom.h"
 #include "content/public/common/service_registry.h"
 #include "content/public/renderer/render_frame.h"
 #include "third_party/WebKit/public/platform/modules/presentation/WebPresentationController.h"
+#include "third_party/WebKit/public/platform/modules/presentation/WebPresentationError.h"
 
 namespace content {
 
 PresentationDispatcher::PresentationDispatcher(RenderFrame* render_frame)
     : RenderFrameObserver(render_frame),
       controller_(nullptr) {
 }
 
 PresentationDispatcher::~PresentationDispatcher() {
   // Controller should be destroyed before the dispatcher when frame is
@@ skipping 16 matching lines @@
   if (watched) {
     presentation_service_->GetScreenAvailability(
         mojo::String(),
         base::Bind(&PresentationDispatcher::OnScreenAvailabilityChanged,
                  base::Unretained(this)));
   } else {
     presentation_service_->OnScreenAvailabilityListenerRemoved();
   }
 }
 
+void PresentationDispatcher::startSession(
+    const blink::WebString& presentationUrl,
+    const blink::WebString& presentationId,
+    blink::WebPresentationSessionClientCallbacks* callback) {
+  ConnectToPresentationServiceIfNeeded();
+  presentation_service_->StartSession(
+      presentationUrl.utf8(),
+      presentationId.utf8(),
+      base::Bind(&PresentationDispatcher::OnSessionCreated,
+          base::Unretained(this),
+          base::Unretained(callback)));

[mlamouri (slow - plz ping), 2015/02/23 14:07:39]

base::Owned(callback)

[whywhat, 2015/02/25 14:12:41]

Done. Actually atm the callback owns/deletes itself but this seems to be
cleaner.

+}
+
+void PresentationDispatcher::joinSession(
+    const blink::WebString& presentationUrl,
+    const blink::WebString& presentationId,
+    blink::WebPresentationSessionClientCallbacks* callback) {
+  ConnectToPresentationServiceIfNeeded();
+  presentation_service_->JoinSession(
+      presentationUrl.utf8(),
+      presentationId.utf8(),
+      base::Bind(&PresentationDispatcher::OnSessionCreated,
+          base::Unretained(this),
+          base::Unretained(callback)));

[mlamouri (slow - plz ping), 2015/02/23 14:07:39]

ditto

[whywhat, 2015/02/25 14:12:41]

Done.

+}
+
 void PresentationDispatcher::OnScreenAvailabilityChanged(bool available) {
   if (!controller_)
     return;
 
   // Reset the callback to get the next event.
   updateAvailableChangeWatched(controller_->isAvailableChangeWatched());
 
   controller_->didChangeAvailability(available);
 }
 
+void PresentationDispatcher::OnSessionCreated(
+    blink::WebPresentationSessionClientCallbacks* callback,
+    presentation::PresentationSessionInfoPtr session_info,
+    presentation::PresentationErrorPtr error) {
+  if (!callback)
+    return;
+  if (!error.is_null()) {
+    DCHECK(session_info.is_null());
+    callback->onError(new blink::WebPresentationError(
+        error->errorCode,

[mlamouri (slow - plz ping), 2015/02/23 14:07:39]

You will need a switch to go from PresentationService error types to Blink error
types.

[whywhat, 2015/02/25 14:12:41]

Done.

+        blink::WebString::fromUTF8(error->message)));
+    return;
+  }
+
+  DCHECK(!session_info.is_null());
+  PresentationSessionDispatcher* session_dispatcher =
+      new PresentationSessionDispatcher(session_info.Pass());
+  presentation_sessions_.push_back(session_dispatcher);
+  callback->onSuccess(session_dispatcher);

[mlamouri (slow - plz ping), 2015/02/23 14:07:39]

PresentationDispatcher owns the callback. Please delete it.

[whywhat, 2015/02/25 14:12:41]

As I understand, it will be deleted automatically if I use base::Owned?

+}
+
 void PresentationDispatcher::ConnectToPresentationServiceIfNeeded() {
   if (presentation_service_.get())
     return;
 
   render_frame()->GetServiceRegistry()->ConnectToRemoteService(
       &presentation_service_);
 }
 
 }  // namespace content