Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/base/sdch_manager.cc

Issue 935073003: Instrument SdchOwner for clock nullification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed try job errors. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/sdch/sdch_owner.h » ('j') | net/sdch/sdch_owner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/sdch_manager.cc
diff --git a/net/base/sdch_manager.cc b/net/base/sdch_manager.cc
index 27d86ee858f61e581c2197dca5edfe62eb2e2ea5..7828f9071ff1bbb172b842a69c35e799f9b118d4 100644
--- a/net/base/sdch_manager.cc
+++ b/net/base/sdch_manager.cc
@@ -259,6 +259,12 @@ SdchManager::~SdchManager() {
auto it = dictionaries_.begin();
dictionaries_.erase(it->first);
}
+#if defined(OS_CHROMEOS)
+ // For debugging http://crbug.com/454198; remove when resolved.
+
+ // Explicitly confirm that we can't notify any observers anymore.
+ CHECK(!observers_.might_have_observers());
+#endif
}
void SdchManager::ClearData() {
« no previous file with comments | « no previous file | net/sdch/sdch_owner.h » ('j') | net/sdch/sdch_owner.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698