Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 935033004: Introduce and test NodeProperties::CollectControlProjections. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce and test NodeProperties::CollectControlProjections. R=bmeurer@chromium.org TEST=unittests/NodePropertiesTest.CollectControlProjections Committed: https://crrev.com/7e7e85f32e9336a2c5e38b67bd1bb01fa2915a40 Cr-Commit-Position: refs/heads/master@{#26720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -61 lines) Patch
M src/compiler/control-flow-optimizer.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/node-properties.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M src/compiler/scheduler.cc View 1 chunk +7 lines, -51 lines 0 comments Download
M test/unittests/compiler/node-properties-unittest.cc View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-18 13:35:20 UTC) #1
Benedikt Meurer
LGTM
5 years, 10 months ago (2015-02-18 13:36:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935033004/1
5 years, 10 months ago (2015-02-18 13:41:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 13:55:29 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 13:55:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e7e85f32e9336a2c5e38b67bd1bb01fa2915a40
Cr-Commit-Position: refs/heads/master@{#26720}

Powered by Google App Engine
This is Rietveld 408576698