Issue 9350041: Switch to dartgenerator.py for C++ callbacks generation.

Issue 9350041: Switch to dartgenerator.py for C++ callbacks generation. (Closed)

Created:
8 years, 10 months ago by podivilov

Modified:
8 years, 10 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Switch to dartgenerator.py for C++ callbacks generation. R=antonm@google.com Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=167

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -2350 lines)			Patch
M	Source/WebCore/bindings/dart/DartCallback.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/WebCore/bindings/dart/DartDOMWrapper.h	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	Source/WebCore/bindings/dart/DartDOMWrapper.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	Source/WebCore/bindings/dart/custom/DartDOMStringMapCustom.cpp	View	1 chunk	+0 lines, -147 lines	0 comments	Download
D	Source/WebCore/bindings/dart/custom/DartInjectedScriptHostCustom.cpp	View	1 chunk	+0 lines, -97 lines	0 comments	Download
D	Source/WebCore/bindings/dart/custom/DartInspectorFrontendHostCustom.cpp	View	1 chunk	+0 lines, -79 lines	0 comments	Download
A +	Source/WebCore/bindings/dart/custom/DartMessageChannelCustom.cpp	View	2 chunks	+5 lines, -56 lines	0 comments	Download
A +	Source/WebCore/bindings/dart/custom/DartUint8ClampedArrayCustom.cpp	View	2 chunks	+8 lines, -35 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartWebKitMutationObserverCustom.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/WebCore/bindings/dart/gyp/dartium.gyp	View	5 chunks	+10 lines, -87 lines	0 comments	Download
M	Source/WebCore/bindings/dart/gyp/overrides.gypi	View	7 chunks	+7 lines, -6 lines	0 comments	Download
D	Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm	View	1 chunk	+0 lines, -1782 lines	0 comments	Download
M	Source/WebCore/bindings/dart/gyp/scripts/build_dart_snapshot.py	View	2 chunks	+3 lines, -56 lines	0 comments	Download
M	Source/WebCore/dom/Node.idl	View	1 chunk	+1 line, -1 line	1 comment	Download
M	Source/WebCore/notifications/NotificationCenter.idl	View	1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

LGTM, but I am concerned why you modify new IDLs and do not revert our ...

8 years, 10 months ago (2012-02-13 19:20:03 UTC) #2

podivilov

8 years, 10 months ago (2012-02-14 12:47:24 UTC) #3

On 2012/02/13 19:20:03, antonm wrote:
> LGTM, but I am concerned why you modify new IDLs and do not revert our current
> changes to other IDLs.
> 
>
https://chromiumcodereview.appspot.com/9350041/diff/1/Source/WebCore/dom/Node...
> File Source/WebCore/dom/Node.idl (right):
> 
>
https://chromiumcodereview.appspot.com/9350041/diff/1/Source/WebCore/dom/Node...
> Source/WebCore/dom/Node.idl:75: raises(DOMException);
> is it a revert?
> 
>
https://chromiumcodereview.appspot.com/9350041/diff/1/Source/WebCore/notifica...
> File Source/WebCore/notifications/NotificationCenter.idl (right):
> 
>
https://chromiumcodereview.appspot.com/9350041/diff/1/Source/WebCore/notifica...
> Source/WebCore/notifications/NotificationCenter.idl:42: [V8Custom]
Notification
> createNotification(in DOMString iconUrl, in DOMString title, in DOMString
body)
> raises(DOMException);
> are not we aiming for 0 changes to idls?

Thanks. Corresponding change for idls is already landed upstream.

Expand Messages | Collapse Messages