Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 934963003: Apply WTF::ParamStorageTraits<> to CrossThreadTaskN. (Closed)

Created:
5 years, 10 months ago by tkent
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Apply WTF::ParamStorageTraits<> to CrossThreadTaskN. Before this CL, a pointer to a GarbageCollected object is stored by RawPtr<T> or T* in CrossThreadTaskN. If a GC happened before the task is performed, the object can be swept. Applying ParamStorageTraits makes it CrossThreadPersistent<T>, and we can safely use createCrossThreadTask() for GarbageCollected objects. BUG=378192 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190638

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -108 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/CrossThreadTask.h View 9 chunks +127 lines, -108 lines 0 comments Download
A Source/core/dom/CrossThreadTaskTest.cpp View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tkent
Please review this.
5 years, 10 months ago (2015-02-18 09:22:11 UTC) #4
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-18 12:29:59 UTC) #6
hiroshige
lgtm in terms of thread safety. (but not sure about Oilpan-related issues)
5 years, 10 months ago (2015-02-19 06:44:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934963003/40001
5 years, 10 months ago (2015-02-23 06:11:43 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 06:14:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190638

Powered by Google App Engine
This is Rietveld 408576698