Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: site/dev/chrome/changes.md

Issue 934893003: managing chromes use section of docs (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix formatting nit Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site/dev/chrome/blink.md ('k') | site/dev/chrome/index.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site/dev/chrome/changes.md
diff --git a/site/dev/chrome/changes.md b/site/dev/chrome/changes.md
new file mode 100644
index 0000000000000000000000000000000000000000..5ded65752c0fa8469946b058fc9d902dfd9e6490
--- /dev/null
+++ b/site/dev/chrome/changes.md
@@ -0,0 +1,35 @@
+Landing Skia changes which require associated Chrome changes
+============================================================
+
+If your change modifies the Skia API, you may also need to land a change in Chromium.
+
+The strategy you use to synchronize changes in the Skia and Chromium
+repositories may differ based on the nature of the change, but in general, we
+recommend using build flag suppressions \(defines\)\.
+We also prefer making the old code path opt-in where possible.
+
+Method 1 \(preferred\) \- Make the old code path opt\-in for Chromium
+
+ * Add new code to Skia, leaving the old code in place.
+ * Deprecate the old code path so that it must be enabled with a flag such as
+ 'SK_SUPPORT_LEGACY_XXX'.
+ * Synchronize the above changes in Skia with a Chromium commit to
+ 'skia/skia_common.gypi' or 'skia/config/SkUserConfig.h' to enable the
+ deprecated Skia API.
+ * Note that the code suppression cannot exist in both the header file and
+ the gyp file, it should only reside in one location.
+ * Test the new or updated Skia API within Chromium.
+ * Remove the flag and code when the legacy code path is no longer in use.
+
+Method 2 \- Make the new code path opt\-in for Chromium
+
+ * Add new code to Skia, suppressed by a flag.
+ * Leave the old code path in place.
+ * Set the flag in Chromium's 'skia/skia_common.gypi' or
+ 'skia/config/SkUserConfig.h' to enable the new or updated Skia API.
+ * Test the new or updated Skia API within Chromium.
+ * Remove the code suppression \(and code\) when the legacy API is no longer
+ in use.
+
+If your changes will affect Blink layout tests, see detailed instructions about
+how to synchronize the changes between Skia, Blink, and Chromium [here](./blink).
« no previous file with comments | « site/dev/chrome/blink.md ('k') | site/dev/chrome/index.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698