Issue 934893002: Revert of [Android] Migrate DeviceUtils.GetMemoryUsageForPid to adb_wrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 934893002: Revert of [Android] Migrate DeviceUtils.GetMemoryUsageForPid to adb_wrapper. (Closed)

Created:
5 years, 10 months ago by jam

Modified:
5 years, 10 months ago

Reviewers:
perezju, jbudorick

CC:
chromium-reviews, telemetry-reviews_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of [Android] Migrate DeviceUtils.GetMemoryUsageForPid to adb_wrapper. (patchset #5 id:80001 of https://codereview.chromium.org/924003003/) Reason for revert: Collision with https://codereview.chromium.org/929603002, see failurs on trybots like http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/2499/steps/pylib_py_unittests/logs/stdio Original issue's description: > [Android] Migrate DeviceUtils.GetMemoryUsageForPid to adb_wrapper. > > BUG=267773 > > Committed: https://crrev.com/bcec82d59869b43f0507d244e84798c6ce1cfcf9 > Cr-Commit-Position: refs/heads/master@{#316624} TBR=perezju@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/2c30f6f1f44561898cdd98a262e87c3804af6dff Cr-Commit-Position: refs/heads/master@{#316653}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -120 lines)			Patch
	M	build/android/pylib/device/device_utils.py	View		2 chunks	+8 lines, -50 lines	0 comments	Download
	M	build/android/pylib/device/device_utils_test.py	View		35 chunks	+125 lines, -70 lines	0 comments	Download

Total messages: 4 (0 generated)

jam

Created Revert of [Android] Migrate DeviceUtils.GetMemoryUsageForPid to adb_wrapper.

5 years, 10 months ago (2015-02-17 21:11:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934893002/1

5 years, 10 months ago (2015-02-17 21:12:27 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-17 21:14:38 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2c30f6f1f44561898cdd98a262e87c3804af6dff
Cr-Commit-Position: refs/heads/master@{#316653}