build/android/java_cpp_enum.gypi - Issue 934873002: Improve CLI interface of C++ enums to Java generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/java_cpp_enum.gypi

Issue 934873002: Improve CLI interface of C++ enums to Java generator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments & rebased Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/java_cpp_enum.gypi

diff --git a/build/android/java_cpp_enum.gypi b/build/android/java_cpp_enum.gypi

index 3d6b3266af0861125da5953bc1476d63dcfebb1a..b51351b01757517d3ed66f71c03df8ac9b09ddf8 100644

--- a/build/android/java_cpp_enum.gypi

+++ b/build/android/java_cpp_enum.gypi

@@ -24,7 +24,7 @@

# Location where all generated Java sources will be placed.

'output_dir': '<(SHARED_INTERMEDIATE_DIR)/enums/<(_target_name)',

'generator_path': '<(DEPTH)/build/android/gyp/java_cpp_enum.py',

- 'generator_args': '--output_dir=<(output_dir) <(source_file)',

+ 'generator_args': '<(output_dir) <(source_file)',

'direct_dependent_settings': {

'variables': {

« no previous file with comments | « build/android/gyp/java_cpp_enum_tests.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »