Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: build/config/android/rules.gni

Issue 934873002: Improve CLI interface of C++ enums to Java generator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Proper gn change Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/gyp/java_cpp_enum.py ('K') | « build/android/java_cpp_enum.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 021a7a04f2498077cb6b2407861df0365d460578..4e74e88c0bc1c58d94e095cb393bc20cbebb97a7 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -323,8 +323,8 @@ template("java_cpp_template") {
#
# outputs: list of outputs, relative to the output_dir. These paths are
# verified at build time by the script. To get the list programatically run:
-# python build/android/gyp/java_cpp_enum.py --output_dir=. \
-# --print_output_only path/to/header/file.h
+# python build/android/gyp/java_cpp_enum.py \
+# --print_output_only . path/to/header/file.h
#
# Example
# java_cpp_enum("foo_generated_enum") {
@@ -351,16 +351,14 @@ template("java_cpp_enum") {
outputs =
get_path_info(rebase_path(invoker.outputs, ".", gen_dir), "abspath")
- args = [
- "--output_dir",
- rebase_path(gen_dir, root_build_dir),
- ]
+ args = []
foreach(output, rebase_path(outputs, root_build_dir)) {
args += [
"--assert_file",
output,
]
}
+ args += rebase_path(gen_dir, root_build_dir)
cjhopman 2015/02/17 21:38:25 gen_dir is a string (invoker.sources below is a li
mnaganov (inactive) 2015/02/23 11:35:26 I was supposing that gn can handle coercion itself
args += rebase_path(invoker.sources, root_build_dir)
}
« build/android/gyp/java_cpp_enum.py ('K') | « build/android/java_cpp_enum.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698