Improve CLI interface of C++ enums to Java generator

build/android/gyp/java_cpp_enum.py

 #!/usr/bin/env python
 #
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import re
 import optparse
 import os
@@ skipping 210 matching lines @@
           original_enum_name=enum_start.groups()[1],
           fixed_type=enum_start.groups()[3])
       self._in_enum = True
 
 def GetScriptName():
   script_components = os.path.abspath(sys.argv[0]).split(os.path.sep)
   build_index = script_components.index('build')
   return os.sep.join(script_components[build_index:])
 
 
-def DoGenerate(options, source_paths):
+def DoGenerate(options, output_dir_and_source_paths):

[cjhopman, 2015/02/17 21:38:25]

extracting out bits of the list like this is odd, can we do:
def DoGenerate(options, output_dir, source_paths):

[mnaganov (inactive), 2015/02/23 11:35:26]

Done.

+  output_dir = output_dir_and_source_paths[0]
+  source_paths = output_dir_and_source_paths[1:]
   output_paths = []
   for source_path in source_paths:
     enum_definitions = DoParseHeaderFile(source_path)
+    if not enum_definitions:
+      raise Exception('No enums found in %s\n'
+                      'Did you forget prefixing enums with '
+                      '"// GENERATED_JAVA_ENUM_PACKAGE: foo"?' %
+                      source_path)
     for enum_definition in enum_definitions:
       package_path = enum_definition.enum_package.replace('.', os.path.sep)
       file_name = enum_definition.class_name + '.java'
-      output_path = os.path.join(options.output_dir, package_path, file_name)
+      output_path = os.path.join(output_dir, package_path, file_name)
       output_paths.append(output_path)
       if not options.print_output_only:

[cjhopman, 2015/02/17 21:38:25]

We could totally get rid of the options argument here if we just passed this
flag explicitly as well.

[mnaganov (inactive), 2015/02/23 11:35:26]

Done.

         build_utils.MakeDirectory(os.path.dirname(output_path))
         DoWriteOutput(source_path, output_path, enum_definition)
   return output_paths
 
 
 def DoParseHeaderFile(path):
   with open(path) as f:
     return HeaderParser(f.readlines(), path).ParseDefinitions()
 
 
@@ skipping 42 matching lines @@
 def AssertFilesList(output_paths, assert_files_list):
   actual = set(output_paths)
   expected = set(assert_files_list)
   if not actual == expected:
     need_to_add = list(actual - expected)
     need_to_remove = list(expected - actual)
     raise Exception('Output files list does not match expectations. Please '
                     'add %s and remove %s.' % (need_to_add, need_to_remove))
 
 def DoMain(argv):
-  parser = optparse.OptionParser()
+  usage = 'usage: %prog [options] output_dir input_file(s)...'
+  parser = optparse.OptionParser(usage=usage)
 
   parser.add_option('--assert_file', action="append", default=[],
                     dest="assert_files_list", help='Assert that the given '
                     'file is an output. There can be multiple occurrences of '
                     'this flag.')
-  parser.add_option('--output_dir', help='Base path for generated files.')
   parser.add_option('--print_output_only', help='Only print output paths.',
                     action='store_true')
 
   options, args = parser.parse_args(argv)
-
+  if len(args) < 2:
+    parser.error('Need to specify output directory and at least one input file')
   output_paths = DoGenerate(options, args)
 
   if options.assert_files_list:
     AssertFilesList(output_paths, options.assert_files_list)
 
   return " ".join(output_paths)
 
 if __name__ == '__main__':
-  DoMain(sys.argv[1:])
+  print DoMain(sys.argv[1:])

[cjhopman, 2015/02/17 21:38:25]

We try to limit the output in a normal build, so I'd avoid printing this. If
this information is useful for debugging we could do something like a --verbose
flag (or a --quiet flag used in the build) and print more information.

[mnaganov (inactive), 2015/02/23 11:35:26]

I see. Added a flag then.