Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sky/tests/dom/appendChild.sky

Issue 934863002: ParentNode#appendChild(null) shouldn't crash (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: git cl format Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sky/engine/tonic/dart_exception_factory.cc ('K') | « sky/engine/tonic/dart_wrappable.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tests/dom/appendChild.sky
diff --git a/sky/tests/dom/appendChild.sky b/sky/tests/dom/appendChild.sky
index 57a6a2ff87a565ba92372fd9ccf097c647d2740c..35494a0a596856bfbd7690e8c62997cb1db706a6 100644
--- a/sky/tests/dom/appendChild.sky
+++ b/sky/tests/dom/appendChild.sky
@@ -17,10 +17,9 @@ void main() {
expect(() {
parent.appendChild();
}, throws);
- // TODO(dart): This is a real bug.
- // expect(() {
- // parent.appendChild(null);
- // }, throws);
+ expect(() {
+ parent.appendChild(null);
+ }, throws);
expect(() {
parent.appendChild({tagName: "div"});
}, throws);
« sky/engine/tonic/dart_exception_factory.cc ('K') | « sky/engine/tonic/dart_wrappable.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698