Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: sky/engine/tonic/dart_state.h

Issue 934863002: ParentNode#appendChild(null) shouldn't crash (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: git cl format Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/tonic/dart_state.h
diff --git a/sky/engine/tonic/dart_state.h b/sky/engine/tonic/dart_state.h
index 88a0b4af86a0ca78bfb6c1356b46e17cf35d1ca9..967fceb6e6f2a8ec55728c29f0d371114466e186 100644
--- a/sky/engine/tonic/dart_state.h
+++ b/sky/engine/tonic/dart_state.h
@@ -16,6 +16,7 @@
namespace blink {
class DartStringCache;
class DartClassLibrary;
+class DartExceptionFactory;
// DartState represents the state associated with a given Dart isolate. The
// lifetime of this object is controlled by the DartVM. If you want to hold a
@@ -46,11 +47,13 @@ class DartState : public base::SupportsUserData {
DartClassLibrary& class_library() { return *class_library_; }
DartStringCache& string_cache() { return *string_cache_; }
+ DartExceptionFactory& exception_factory() { return *exception_factory_; }
private:
Dart_Isolate isolate_;
OwnPtr<DartClassLibrary> class_library_;
OwnPtr<DartStringCache> string_cache_;
+ OwnPtr<DartExceptionFactory> exception_factory_;
base::WeakPtrFactory<DartState> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698