Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: sky/engine/tonic/dart_state.cc

Issue 934863002: ParentNode#appendChild(null) shouldn't crash (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: git cl format Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sky/engine/config.h" 5 #include "sky/engine/config.h"
6 #include "sky/engine/tonic/dart_state.h" 6 #include "sky/engine/tonic/dart_state.h"
7 7
8 #include "sky/engine/tonic/dart_class_library.h" 8 #include "sky/engine/tonic/dart_class_library.h"
9 #include "sky/engine/tonic/dart_string_cache.h" 9 #include "sky/engine/tonic/dart_string_cache.h"
10 #include "sky/engine/tonic/dart_exception_factory.h"
10 #include "sky/engine/wtf/PassOwnPtr.h" 11 #include "sky/engine/wtf/PassOwnPtr.h"
11 12
12 namespace blink { 13 namespace blink {
13 14
14 DartState::Scope::Scope(DartState* dart_state) { 15 DartState::Scope::Scope(DartState* dart_state) {
15 } 16 }
16 17
17 DartState::Scope::~Scope() { 18 DartState::Scope::~Scope() {
18 } 19 }
19 20
20 DartState::DartState() 21 DartState::DartState()
21 : isolate_(NULL), 22 : isolate_(NULL),
22 class_library_(adoptPtr(new DartClassLibrary)), 23 class_library_(adoptPtr(new DartClassLibrary)),
23 string_cache_(adoptPtr(new DartStringCache)), 24 string_cache_(adoptPtr(new DartStringCache)),
25 exception_factory_(adoptPtr(new DartExceptionFactory(this))),
24 weak_factory_(this) { 26 weak_factory_(this) {
25 } 27 }
26 28
27 DartState::~DartState() { 29 DartState::~DartState() {
28 } 30 }
29 31
30 DartState* DartState::From(Dart_Isolate isolate) { 32 DartState* DartState::From(Dart_Isolate isolate) {
31 return static_cast<DartState*>(Dart_IsolateData(isolate)); 33 return static_cast<DartState*>(Dart_IsolateData(isolate));
32 } 34 }
33 35
34 DartState* DartState::Current() { 36 DartState* DartState::Current() {
35 return static_cast<DartState*>(Dart_CurrentIsolateData()); 37 return static_cast<DartState*>(Dart_CurrentIsolateData());
36 } 38 }
37 39
38 base::WeakPtr<DartState> DartState::GetWeakPtr() { 40 base::WeakPtr<DartState> DartState::GetWeakPtr() {
39 return weak_factory_.GetWeakPtr(); 41 return weak_factory_.GetWeakPtr();
40 } 42 }
41 43
42 } // namespace blink 44 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698