Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc

Issue 934843002: Implement DeviceMotionEvent API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update Thread Safety Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc
diff --git a/content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc b/content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc
index 6dc0336e7a509eda48d0432ca73581006aa73379..2bfbf77c496cf9612832e19756859ec657fa7868 100644
--- a/content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc
+++ b/content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc
@@ -21,9 +21,9 @@ bool DataFetcherSharedMemory::Start(ConsumerType consumer_type, void* buffer) {
switch (consumer_type) {
case CONSUMER_TYPE_MOTION:
- // TODO(jonross): Implement Device Motion API. (crbug.com/427662)
- NOTIMPLEMENTED();
- return false;
+ sensor_manager_->StartFetchingDeviceMotionData(
+ static_cast<DeviceMotionHardwareBuffer*>(buffer));
+ return true;
case CONSUMER_TYPE_ORIENTATION:
return sensor_manager_->StartFetchingDeviceOrientationData(
static_cast<DeviceOrientationHardwareBuffer*>(buffer));
flackr 2015/02/25 23:15:17 nit: same applies here right? StartFetchingDeviceO
jonross 2015/03/02 15:18:10 Done.
@@ -38,8 +38,7 @@ bool DataFetcherSharedMemory::Start(ConsumerType consumer_type, void* buffer) {
bool DataFetcherSharedMemory::Stop(ConsumerType consumer_type) {
switch (consumer_type) {
case CONSUMER_TYPE_MOTION:
- NOTIMPLEMENTED();
- return false;
+ return sensor_manager_->StopFetchingDeviceMotionData();
case CONSUMER_TYPE_ORIENTATION:
return sensor_manager_->StopFetchingDeviceOrientationData();
case CONSUMER_TYPE_LIGHT:

Powered by Google App Engine
This is Rietveld 408576698