Rename SPDY netlog strings to HTTP2.

Rename SPDY netlog strings to HTTP2.

s/SPDY/HTTP2/ in all source type and event type netlog strings.
Also remove obsolete TYPE_SPDY_SESSION_SEND_CREDENTIAL.
Also git cl format.

BUG=456986
Committed: https://crrev.com/be32a03b9859d7669b372908d575a232714925ce
Cr-Commit-Position: refs/heads/master@{#318068}

[Bence, 2015-02-17 20:08:11]

bnc@chromium.org changed reviewers:
+ igrigorik@chromium.org

[Bence, 2015-02-17 20:08:11]

Ilya, WDYT?  Now SPDY/3.1 netlog events (even ones like SYN_REPLY frame that do
not occur in HTTP/2) will also have a HTTP/2 label (like
HTTP2_SESSION_SYN_REPLY), but otherwise I feel like this is what we want.

Duplicating every SPDY_* macro as HTTP2_*, and using them for SPDY/3.1 and
HTTP/2 respectively would create quite some extra complexity (to be undone in a
year anyway).

[igrigorik, 2015-02-17 21:49:53]

One thing that's confusing me: if we're talking over HTTP/2, how/why are we
still logging SYN_STREAM's? Shouldn't those be reported as HEADERS, etc?

[Bence, 2015-02-18 12:56:10]

On 2015/02/17 21:49:53, igrigorik wrote:
> One thing that's confusing me: if we're talking over HTTP/2, how/why are we
> still logging SYN_STREAM's? Shouldn't those be reported as HEADERS, etc?

Yes, you are right.  I'll fix that in SpdySession::CreateSynStream() in the next
CL.  (Unless you want me to do that first.)

[igrigorik, 2015-02-18 17:28:36]

On 2015/02/18 12:56:10, Bence wrote:
> On 2015/02/17 21:49:53, igrigorik wrote:
> > One thing that's confusing me: if we're talking over HTTP/2, how/why are we
> > still logging SYN_STREAM's? Shouldn't those be reported as HEADERS, etc?
> 
> Yes, you are right.  I'll fix that in SpdySession::CreateSynStream() in the
next
> CL.  (Unless you want me to do that first.)

Ah, great. No, the order doesn't matter to me, just wasn't sure what our plan
was surfacing http/2 frames, etc.

[igrigorik, 2015-02-18 17:30:11]

lgtm

lgtm

[mmenke, 2015-02-18 17:35:37]

mmenke@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2015-02-18 17:35:38]

https://codereview.chromium.org/934823005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/net_internals/spdy_view.html (right):

https://codereview.chromium.org/934823005/diff/20001/chrome/browser/resources...
chrome/browser/resources/net_internals/spdy_view.html:15: <a
href="#events&q=type:HTTP2_SESSION%20is:active">View live HTTP/2 sessions</a>
This is source type, not event type.  See net_log_source_type_list.h.  Also note
that there's a reference to the source type at
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
as well.

[Bence, 2015-02-20 16:29:15]

New patchsets have been uploaded after l-g-t-m from igrigorik@chromium.org

[Bence, 2015-02-20 20:30:12]

Matt, PTAL.  Thank you.

https://codereview.chromium.org/934823005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/net_internals/spdy_view.html (right):

https://codereview.chromium.org/934823005/diff/20001/chrome/browser/resources...
chrome/browser/resources/net_internals/spdy_view.html:15: <a
href="#events&q=type:HTTP2_SESSION%20is:active">View live HTTP/2 sessions</a>
On 2015/02/18 17:35:38, mmenke wrote:
> This is source type, not event type.  See net_log_source_type_list.h.  Also
note
> that there's a reference to the source type at
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> as well.

Awesome, thanks for catching it.  I thus replaced source types too.

Done.

[mmenke, 2015-02-20 21:42:32]

On 2015/02/20 20:30:12, Bence wrote:
> Matt, PTAL.  Thank you.
> 
>
https://codereview.chromium.org/934823005/diff/20001/chrome/browser/resources...
> File chrome/browser/resources/net_internals/spdy_view.html (right):
> 
>
https://codereview.chromium.org/934823005/diff/20001/chrome/browser/resources...
> chrome/browser/resources/net_internals/spdy_view.html:15: <a
> href="#events&q=type:HTTP2_SESSION%20is:active">View live HTTP/2 sessions</a>
> On 2015/02/18 17:35:38, mmenke wrote:
> > This is source type, not event type.  See net_log_source_type_list.h.  Also
> note
> > that there's a reference to the source type at
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> > as well.
> 
> Awesome, thanks for catching it.  I thus replaced source types too.
> 
> Done.

LGTM, but I suggest waiting until after branch before landing - can take a while
to notice minor bugs that only show up in net-internals.

[Bence, 2015-02-24 17:11:15]

bnc@chromium.org changed reviewers:
+ dgozman@chromium.org

[Bence, 2015-02-24 17:11:16]

Dmitry: PTAL at content/browser/devtools/devtools_netlog_observer.cc.  Thank
you.

[dgozman, 2015-02-24 18:57:49]

devtools_netlog_observer.cc lgtm
Feel free to TBR such a trivial change next time.

[Bence, 2015-02-25 16:05:22]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2015-02-25 16:06:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/934823005/40001

[commit-bot: I haz the power, 2015-02-25 17:23:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-25 17:23:40]

Patchset 3 (id:??) landed as
https://crrev.com/be32a03b9859d7669b372908d575a232714925ce
Cr-Commit-Position: refs/heads/master@{#318068}