Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 934793002: Made WebRTC AQ test two-way, adjusted volume on Mac. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@threading_fake_device
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made WebRTC AQ test two-way, adjusted volume on Mac. It turns out automated echo cancellation only gets enabled for two-way calls. Since we want to test the complex AEC in WebRTC (and the other audio processing for that matter), we must make the test call two-way rather than one-way as it used to be for simplicity. With these changes, we should be able to catch bugs like 453907 on the desktop platforms. Note: should land together with https://codereview.chromium.org/922663002/. BUG=453907 Committed: https://crrev.com/7ece40694beef0b342a776506040254f7110eb40 Cr-Commit-Position: refs/heads/master@{#317560}

Patch Set 1 #

Patch Set 2 : Also re-enabling test on mac (since this patch fixes that test) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/test/data/webrtc/peerconnection.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
phoglund_chromium
5 years, 10 months ago (2015-02-17 13:19:59 UTC) #2
henrika (OOO until Aug 14)
LGTM
5 years, 10 months ago (2015-02-17 13:36:13 UTC) #3
phoglund_chromium
I forgot to actually re-enable the test on mac, so I uploaded a patch set ...
5 years, 10 months ago (2015-02-20 14:24:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934793002/20001
5 years, 10 months ago (2015-02-23 10:27:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 10:30:19 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 10:31:00 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ece40694beef0b342a776506040254f7110eb40
Cr-Commit-Position: refs/heads/master@{#317560}

Powered by Google App Engine
This is Rietveld 408576698