Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 934773005: Rename SPDY to HTTP/2 on NetLog tab. (Closed)

Created:
5 years, 10 months ago by Bence
Modified:
5 years, 10 months ago
Reviewers:
mmenke
CC:
chromium-reviews, eroman, arv+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SPDY to HTTP/2 on NetLog tab. Rename SPDY tab to HTTP/2, and replace "SPDY" with "HTTP/2" on this tab wherever it makes sense. Do not rename internal strings (variable names and such). BUG=456986 Committed: https://crrev.com/d57541d8ae564ed5dfd2c4047fcbd126c798b662 Cr-Commit-Position: refs/heads/master@{#316642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/resources/net_internals/spdy_view.html View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/net_internals/spdy_view.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Matt, PTAL. Thanks.
5 years, 10 months ago (2015-02-17 20:03:47 UTC) #2
mmenke
LGTM
5 years, 10 months ago (2015-02-17 20:11:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934773005/1
5 years, 10 months ago (2015-02-17 20:21:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 20:25:05 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 20:26:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d57541d8ae564ed5dfd2c4047fcbd126c798b662
Cr-Commit-Position: refs/heads/master@{#316642}

Powered by Google App Engine
This is Rietveld 408576698