Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 934773004: Roll ANGLE 592ab9dd91e6..d2d21dcadcc. (Closed)

Created:
5 years, 10 months ago by Jamie Madill
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
Jamie Madill
PTAL
5 years, 10 months ago (2015-02-17 19:38:20 UTC) #1
bajones
Which win trybots use clang? I'd really prefer to avoid a third revert. LGTM assuming ...
5 years, 10 months ago (2015-02-17 19:41:59 UTC) #2
Jamie Madill
Nico tested with Clang-Win locally.
5 years, 10 months ago (2015-02-17 19:42:44 UTC) #3
Jamie Madill
On 2015/02/17 19:42:44, Jamie Madill wrote: > Nico tested with Clang-Win locally. Oh, to answer ...
5 years, 10 months ago (2015-02-17 19:43:24 UTC) #4
bajones
On 2015/02/17 at 19:43:24, jmadill wrote: > On 2015/02/17 19:42:44, Jamie Madill wrote: > > ...
5 years, 10 months ago (2015-02-17 19:44:30 UTC) #5
Nico
lgtm Correct, there's no clang/win trybots yet. This did build fine locally for me though, ...
5 years, 10 months ago (2015-02-17 19:44:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934773004/1
5 years, 10 months ago (2015-02-17 19:48:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 19:53:24 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 19:54:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ebf46e9c536323affb26a8c08667537bc21e1b5
Cr-Commit-Position: refs/heads/master@{#316633}

Powered by Google App Engine
This is Rietveld 408576698