src/flag-definitions.h - Issue 934773002: Add historgram for number of GC needed to collect a detached context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flag-definitions.h

Issue 934773002: Add historgram for number of GC needed to collect a detached context. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Make tracking default, add tracing, and fix a bug. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/flag-definitions.h

diff --git a/src/flag-definitions.h b/src/flag-definitions.h

index e43f565c3cff7b1ce0b228c2e605f0061b9a461e..a4b61aafb35966148ff8353d2529ae619e6a88c3 100644

--- a/src/flag-definitions.h

+++ b/src/flag-definitions.h

@@ -620,8 +620,11 @@ DEFINE_BOOL(trace_incremental_marking, false,

"trace progress of the incremental marking")

DEFINE_BOOL(track_gc_object_stats, false,

"track object counts and memory usage")

-DEFINE_BOOL(track_detached_contexts, false,

+DEFINE_BOOL(track_detached_contexts, true,

"track native contexts that are expected to be garbage collected")

+DEFINE_BOOL(trace_detached_contexts, false,

+ "trace native contexts that are expected to be garbage collected")

+DEFINE_IMPLICATION(trace_detached_contexts, track_detached_contexts)

#ifdef VERIFY_HEAP

DEFINE_BOOL(verify_heap, false, "verify heap pointers before and after GC")

#endif

« no previous file with comments | « src/counters.h ('k') | src/isolate.cc » ('j') | no next file with comments »