Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: extensions/renderer/extension_injection_host.cc

Issue 934763003: Refactoring: de-couple Extensions from "script injection System" [render side]:3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decouple_brower_isolated_world_routingid_user_script_1
Patch Set: Devlin's comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/extension_set.h"
5 #include "extensions/common/manifest_handlers/csp_info.h" 6 #include "extensions/common/manifest_handlers/csp_info.h"
6 #include "extensions/renderer/extension_injection_host.h" 7 #include "extensions/renderer/extension_injection_host.h"
7 8
8 namespace extensions { 9 namespace extensions {
9 10
10 ExtensionInjectionHost::ExtensionInjectionHost( 11 ExtensionInjectionHost::ExtensionInjectionHost(
11 const scoped_refptr<const Extension>& extension) 12 const Extension* extension)
12 : InjectionHost(HostID(HostID::EXTENSIONS, extension->id())), 13 : InjectionHost(HostID(HostID::EXTENSIONS, extension->id())),
13 extension_(extension) { 14 extension_(extension) {
14 } 15 }
15 16
16 ExtensionInjectionHost::~ExtensionInjectionHost() { 17 ExtensionInjectionHost::~ExtensionInjectionHost() {
17 } 18 }
18 19
19 const std::string& ExtensionInjectionHost::GetContentSecurityPolicy() const { 20 // static
20 return CSPInfo::GetContentSecurityPolicy(extension_.get()); 21 scoped_ptr<const ExtensionInjectionHost> ExtensionInjectionHost::Create(
22 const std::string& extension_id, const ExtensionSet* extensions) {
23 const Extension* extension = extensions->GetByID(extension_id);
24 if (!extension)
25 return scoped_ptr<const ExtensionInjectionHost>();
26 return scoped_ptr<const ExtensionInjectionHost>(
27 new ExtensionInjectionHost(extension));
28 }
29
30 std::string ExtensionInjectionHost::GetContentSecurityPolicy() const {
31 return CSPInfo::GetContentSecurityPolicy(extension_);
21 } 32 }
22 33
23 const GURL& ExtensionInjectionHost::url() const { 34 const GURL& ExtensionInjectionHost::url() const {
24 return extension_->url(); 35 return extension_->url();
25 } 36 }
26 37
27 const std::string& ExtensionInjectionHost::name() const { 38 const std::string& ExtensionInjectionHost::name() const {
28 return extension_->name(); 39 return extension_->name();
29 } 40 }
30 41
31 PermissionsData::AccessType ExtensionInjectionHost::CanExecuteOnFrame( 42 PermissionsData::AccessType ExtensionInjectionHost::CanExecuteOnFrame(
32 const GURL& document_url, 43 const GURL& document_url,
33 const GURL& top_frame_url, 44 const GURL& top_frame_url,
34 int tab_id, 45 int tab_id,
35 bool is_declarative) const { 46 bool is_declarative) const {
36 // Declarative user scripts use "page access" (from "permissions" section in 47 // Declarative user scripts use "page access" (from "permissions" section in
37 // manifest) whereas non-declarative user scripts use custom 48 // manifest) whereas non-declarative user scripts use custom
38 // "content script access" logic. 49 // "content script access" logic.
39 if (is_declarative) { 50 if (is_declarative) {
40 return extension_->permissions_data()->GetPageAccess( 51 return extension_->permissions_data()->GetPageAccess(
41 extension_.get(), 52 extension_,
42 document_url, 53 document_url,
43 top_frame_url, 54 top_frame_url,
44 tab_id, 55 tab_id,
45 -1, // no process id 56 -1, // no process id
46 nullptr /* ignore error */); 57 nullptr /* ignore error */);
47 } else { 58 } else {
48 return extension_->permissions_data()->GetContentScriptAccess( 59 return extension_->permissions_data()->GetContentScriptAccess(
49 extension_.get(), 60 extension_,
50 document_url, 61 document_url,
51 top_frame_url, 62 top_frame_url,
52 tab_id, 63 tab_id,
53 -1, // no process id 64 -1, // no process id
54 nullptr /* ignore error */); 65 nullptr /* ignore error */);
55 } 66 }
56 } 67 }
57 68
58 bool ExtensionInjectionHost::ShouldNotifyBrowserOfInjection() const { 69 bool ExtensionInjectionHost::ShouldNotifyBrowserOfInjection() const {
59 // We notify the browser of any injection if the extension has no withheld 70 // We notify the browser of any injection if the extension has no withheld
60 // permissions (i.e., the permissions weren't restricted), but would have 71 // permissions (i.e., the permissions weren't restricted), but would have
61 // otherwise been affected by the scripts-require-action feature. 72 // otherwise been affected by the scripts-require-action feature.
62 return extension_->permissions_data()->withheld_permissions()->IsEmpty() && 73 return extension_->permissions_data()->withheld_permissions()->IsEmpty() &&
63 PermissionsData::ScriptsMayRequireActionForExtension( 74 PermissionsData::ScriptsMayRequireActionForExtension(
64 extension_.get(), 75 extension_,
65 extension_->permissions_data()->active_permissions().get()); 76 extension_->permissions_data()->active_permissions().get());
66 } 77 }
67 78
68 } // namespace extensions 79 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698