chrome/browser/extensions/extension_service.cc - Issue 934753005: Automatically grant permissions to default-installed extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 934753005: Automatically grant permissions to default-installed extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index adc9e4fe7f33a096cd8d73c65f75ab6356339d2a..d23a250ebfe98677ea8ca72e9d8061b0836ccd1f 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -1584,12 +1584,10 @@ void ExtensionService::CheckPermissionsIncrease(const Extension* extension,

int disable_reasons = extension_prefs_->GetDisableReasons(extension->id());

bool auto_grant_permission =

- (!is_extension_installed && extension->was_installed_by_default()) ||

+ extension->was_installed_by_default() ||

extensions::ExtensionsBrowserClient::Get()->IsRunningInForcedAppMode();

- // Silently grant all active permissions to default apps only on install.

- // After install they should behave like other apps.

- // Silently grant all active permissions to apps install in kiosk mode on both

- // install and update.

+ // Silently grant all active permissions to default apps and apps installed

+ // in kiosk mode.

not at google - send to devlin 2015/02/17 18:30:36 nit: move this comment above the assignment to aut

if (auto_grant_permission)

GrantPermissions(extension);

« no previous file with comments | « no previous file | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »